cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Podkowinski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
Date Fri, 01 Dec 2017 12:02:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274303#comment-16274303
] 

Stefan Podkowinski commented on CASSANDRA-14061:
------------------------------------------------

[~jay.zhuang], if we're going to make eclipse-warnings a hard requirement for the build, shouldn't
we also fix the reported issues instead of suppressing them? Doing both seems to be a bit
ambivalent to me. 

> trunk eclipse-warnings
> ----------------------
>
>                 Key: CASSANDRA-14061
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Jay Zhuang
>            Assignee: Jay Zhuang
>            Priority: Minor
>
> {noformat}
> eclipse-warnings:
>     [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
>      [echo] Running Eclipse Code Analysis.  Output logged to /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
>      [java] ----------
>      [java] 1. ERROR in /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
(at line 59)
>      [java] 	return new SSTableIdentityIterator(sstable, key, partitionLevelDeletion,
file.getPath(), iterator);
>      [java] 	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>      [java] Potential resource leak: 'iterator' may not be closed at this location
>      [java] ----------
>      [java] 2. ERROR in /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
(at line 79)
>      [java] 	return new SSTableIdentityIterator(sstable, key, partitionLevelDeletion,
dfile.getPath(), iterator);
>      [java] 	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>      [java] Potential resource leak: 'iterator' may not be closed at this location
>      [java] ----------
>      [java] 2 problems (2 errors)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message