cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13976) introduce max_hint_window_in_min, deprecate max_hint_window_in_ms
Date Fri, 01 Dec 2017 01:08:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273767#comment-16273767
] 

Jeff Jirsa commented on CASSANDRA-13976:
----------------------------------------

Encourage you to ask dev@ - I was going to suggest that as well. Pretty -0 on this right now
(it's pretty firmly in the "I wouldn't do this, but I'm not going to really go out of my way
to hard veto it" category).

My primary concern is that as we change yaml params, years of blog posts become irrelevant,
and eventually we'll deprecate out the old ones and remove them, and then someone's rolling
upgrade will break. "Of course you have to change yaml with major versions", you say, but
the less true that is, the better life is for users.


> introduce max_hint_window_in_min, deprecate max_hint_window_in_ms
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-13976
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13976
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jon Haddad
>            Assignee: Kirk True
>            Priority: Minor
>              Labels: lhf
>             Fix For: 4.0
>
>
> Milliseconds is unnecessarily precise.  At most, minutes would be used.  Config in 4.0
should default to a minute granularity, but if the max_hint_window_in_min isn't set should
fall back on max_hint_window_in_ms and emit a warning.
> max_hint_window_in_min: 180 # new default, still at 3 hours.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message