cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13526) nodetool cleanup on KS with no replicas should remove old data, not silently complete
Date Mon, 04 Dec 2017 23:04:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277717#comment-16277717
] 

Jeff Jirsa commented on CASSANDRA-13526:
----------------------------------------

I've rebased your patch and I'm re-running CI, just because it took me so very long to review
this patch.

Generally the patches look fine, but I don't understand why you're running this method twice
[here|https://github.com/jasonstack/cassandra/commit/b51c46565adf0d765ac6ded831469a2eca2939d8#diff-ba6d3d8e296151fc283ef11ac4594e62R211]
(and in the very similar helper below it)?

Other than that, marking as ready-to-commit.

> nodetool cleanup on KS with no replicas should remove old data, not silently complete
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13526
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13526
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Jeff Jirsa
>            Assignee: ZhaoYang
>              Labels: usability
>             Fix For: 3.0.x, 3.11.x, 4.x
>
>
> From the user list:
> https://lists.apache.org/thread.html/5d49cc6bbc6fd2e5f8b12f2308a3e24212a55afbb441af5cb8cd4167@%3Cuser.cassandra.apache.org%3E
> If you have a multi-dc cluster, but some keyspaces not replicated to a given DC, you'll
be unable to run cleanup on those keyspaces in that DC, because [the cleanup code will see
no ranges and exit early|https://github.com/apache/cassandra/blob/4cfaf85/src/java/org/apache/cassandra/db/compaction/CompactionManager.java#L427-L441]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message