Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CB304200D42 for ; Fri, 17 Nov 2017 23:42:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C9AA4160BE6; Fri, 17 Nov 2017 22:42:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1B9D9160BFB for ; Fri, 17 Nov 2017 23:42:03 +0100 (CET) Received: (qmail 16600 invoked by uid 500); 17 Nov 2017 22:42:03 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 16589 invoked by uid 99); 17 Nov 2017 22:42:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Nov 2017 22:42:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 84363C24C1 for ; Fri, 17 Nov 2017 22:42:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id CN2LgsYqgR2w for ; Fri, 17 Nov 2017 22:42:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4BA6D5FD71 for ; Fri, 17 Nov 2017 22:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DD556E0FA2 for ; Fri, 17 Nov 2017 22:42:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8AC1D240E2 for ; Fri, 17 Nov 2017 22:42:00 +0000 (UTC) Date: Fri, 17 Nov 2017 22:42:00 +0000 (UTC) From: "Blake Eggleston (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10726) Read repair inserts should not be blocking MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 17 Nov 2017 22:42:05 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-10726?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16257697#comment-16257697 ]=20 Blake Eggleston commented on CASSANDRA-10726: --------------------------------------------- I opened CASSANDRA-14058 for the refactor since that's sort of a separate t= ask and to keep refactor discussion out of this ticket. There's an initial = implementation up, take a look and let me know what you think.=20 > Read repair inserts should not be blocking > ------------------------------------------ > > Key: CASSANDRA-10726 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1072= 6 > Project: Cassandra > Issue Type: Improvement > Components: Coordination > Reporter: Richard Low > Assignee: Xiaolong Jiang > Fix For: 4.x > > > Today, if there=E2=80=99s a digest mismatch in a foreground read repair, = the insert to update out of date replicas is blocking. This means, if it fa= ils, the read fails with a timeout. If a node is dropping writes (maybe it = is overloaded or the mutation stage is backed up for some other reason), al= l reads to a replica set could fail. Further, replicas dropping writes get = more out of sync so will require more read repair. > The comment on the code for why the writes are blocking is: > {code} > // wait for the repair writes to be acknowledged, to minimize impact on a= ny replica that's > // behind on writes in case the out-of-sync row is read multiple times in= quick succession > {code} > but the bad side effect is that reads timeout. Either the writes should n= ot be blocking or we should return success for the read even if the write t= imes out. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org