cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Whang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-14085) Excessive update of ReadLatency metric in digest calculation
Date Thu, 30 Nov 2017 22:39:01 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Whang updated CASSANDRA-14085:
-------------------------------------
    Fix Version/s: 4.0
                   3.0.16
           Status: Patch Available  (was: Open)

https://github.com/whangsf/cassandra/commit/2ae3589ce9eefd8699bbd4e29bf1c61a486d394e

> Excessive update of ReadLatency metric in digest calculation
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-14085
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14085
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Metrics
>            Reporter: Andrew Whang
>            Priority: Minor
>             Fix For: 3.0.16, 4.0
>
>
> We noticed an increase in read latency after upgrading to 3.x, specifically for requests
with CL>ONE. It turns out the read latency metric is being doubly updated for digest calculations.
This code (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java#L243)
makes an improper copy of an iterator that's wrapped by MetricRecording, whose onClose() records
the latency of the execution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message