cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thibault Kruse (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
Date Wed, 08 Nov 2017 02:36:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243295#comment-16243295
] 

Thibault Kruse commented on CASSANDRA-13997:
--------------------------------------------

For us it would be nice if cassandra 3.x could be made API compatible with Guava > 19.0.
Such as replacing 

Iterators.<RangeTombstone>emptyIterator()

with

Collections.emptyIterator()

as done in

https://github.com/krummas/cassandra/commits/marcuse/guava23

This would not require changing the guava version, just abolishing certain usages of guava
that have been deprecated.

> Upgrade guava to 23.3
> ---------------------
>
>                 Key: CASSANDRA-13997
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18 which we use
now ({{Throwables.propagate}} for example), this patch mostly updates uses where compilation
fails. {{Futures.transform(ListenableFuture ..., AsyncFunction ...}} was deprecated in Guava
19 and removed in 20 for example, we should probably open new tickets to remove calls to all
deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to avoid some
build-time warnings (maybe due to https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
?)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message