cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13215) Cassandra nodes startup time 20x more after upgarding to 3.x
Date Thu, 23 Nov 2017 15:04:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264445#comment-16264445
] 

Paulo Motta commented on CASSANDRA-13215:
-----------------------------------------

bq. both look pretty bad, but I don't think it is because of this patch

yeah, they seem to be a problem with the jolokia agent not working correctly, probably some
configuration error on the CI server.
 
In any case, I ran some failing compaction tests locally and they passed which indicate it's
indeed a problem with CI. 

Patch LGTM, though can you just add a {{toString}} to {{DiskBoundaries}} so the boundary changes
are logged correctly? Marking this as ready to commit so feel free to fix this on commit.

> Cassandra nodes startup time 20x more after upgarding to 3.x
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-13215
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13215
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>         Environment: Cluster setup: two datacenters (dc-main, dc-backup).
> dc-main - 9 servers, no vnodes
> dc-backup - 6 servers, vnodes
>            Reporter: Viktor Kuzmin
>            Assignee: Marcus Eriksson
>             Fix For: 3.11.x, 4.x
>
>         Attachments: simple-cache.patch
>
>
> CompactionStrategyManage.getCompactionStrategyIndex is called on each sstable at startup.
And this function calls StorageService.getDiskBoundaries. And getDiskBoundaries calls AbstractReplicationStrategy.getAddressRanges.
> It appears that last function can be really slow. In our environment we have 1545 tokens
and with NetworkTopologyStrategy it can make 1545*1545 computations in worst case (maybe I'm
wrong, but it really takes lot's of cpu).
> Also this function can affect runtime later, cause it is called not only during startup.
> I've tried to implement simple cache for getDiskBoundaries results and now startup time
is about one minute instead of 25m, but I'm not sure if it's a good solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message