cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Lerer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13006) Disable automatic heap dumps on OOM error
Date Tue, 21 Nov 2017 15:45:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260929#comment-16260929
] 

Benjamin Lerer commented on CASSANDRA-13006:
--------------------------------------------

Thanks for the review.

{quote}
* In our launch scripts, why have a separate JVM_ON_OUT_OF_MEMORY_ERROR_OPT instead of nesting
it inside JVM_OPTS? The latter seems more consistent w/other configuration approaches. This
would also clean up launching branch logic a touch.
{quote}

As bash commands split words on white spaces without taking quotes into account, specifying
the {{OnOutOfMemoryError}} as part of the {{JVM_OPTS}} variable cannot work for an option
value such as: {{kill -9 %p}}. I wasted a couple of days on that and could not come up with
a better solution that the proposed one.

I will take care of the nits.

> Disable automatic heap dumps on OOM error
> -----------------------------------------
>
>                 Key: CASSANDRA-13006
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13006
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Configuration
>            Reporter: anmols
>            Assignee: Benjamin Lerer
>            Priority: Minor
>         Attachments: 13006-3.0.9.txt
>
>
> With CASSANDRA-9861, a change was added to enable collecting heap dumps by default if
the process encountered an OOM error. These heap dumps are stored in the Apache Cassandra
home directory unless configured otherwise (see [Cassandra Support Document|https://support.datastax.com/hc/en-us/articles/204225959-Generating-and-Analyzing-Heap-Dumps]
for this feature).
>  
> The creation and storage of heap dumps aides debugging and investigative workflows, but
is not be desirable for a production environment where these heap dumps may occupy a large
amount of disk space and require manual intervention for cleanups. 
>  
> Managing heap dumps on out of memory errors and configuring the paths for these heap
dumps are available as JVM options in JVM. The current behavior conflicts with the Boolean
JVM flag HeapDumpOnOutOfMemoryError. 
>  
> A patch can be proposed here that would make the heap dump on OOM error honor the HeapDumpOnOutOfMemoryError flag.
Users who would want to still generate heap dumps on OOM errors can set the -XX:+HeapDumpOnOutOfMemoryError JVM
option.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message