Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 18 Oct 2017 11:49:00 +0000 (UTC)
From: =?utf-8?Q?Andr=C3=A9s_de_la_Pe=C3=B1a_=28JIRA=29?= <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13110264.1508324693000.25954.1508327340147@Atlassian.JIRA>
In-Reply-To: <JIRA.13110264.1508324693000@Atlassian.JIRA>
References: <JIRA.13110264.1508324693000@Atlassian.JIRA> <JIRA.13110264.1508324693627@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CASSANDRA-13963)
 SecondaryIndexManagerTest.indexWithfailedInitializationIsNotQueryableAfterPartialRebuild
 is flaky
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 18 Oct 2017 11:49:08 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-13963?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D16209191#comment-16209191 ]=20

Andr=C3=A9s de la Pe=C3=B1a commented on CASSANDRA-13963:
-----------------------------------------------

[Here|https://github.com/apache/cassandra/compare/trunk...adelapena:13963-t=
runk] is a patch solving the problem.

It seems that the call to [{{TestingIndex.shouldFailCreate =3D false;}}|htt=
ps://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/=
index/SecondaryIndexManagerTest.java#L466] is done right after creating the=
 index configured to fail, without waiting for the finalization of the buil=
d task. If we are not lucky the index initalization task can start after di=
sabling the configured fail. In such case, the two calls to {{assertFalse(c=
fs.indexManager.isIndexQueryable(index))}} can either succeed because the i=
ndex build task hasn't started yet (not because it has failed), or fail bec=
ause the task has successfully finished without the configured initializati=
on task failure.

The unit tests usually use [{{CQLTester.waitForIndex}}|https://github.com/a=
pache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/CQLTester.ja=
va#L709-L737] method to wait for the finalization of index builds. In that =
case, since we are making the initialization to fail, we can't rely on this=
 method, so the patch adds a new [{{CQLTester.waitForIndexBuilds}}|https://=
github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/=
CQLTester.java#L709-L737] method to wait for the finalization of index buil=
d tasks independently of their results and the marking procedure. This meth=
od is in {{CQLTester}} instead of {{SecondaryIndexManagerTest}} because I t=
hink it's suitable to be used by other tests.=20

> SecondaryIndexManagerTest.indexWithfailedInitializationIsNotQueryableAfte=
rPartialRebuild is flaky
> -------------------------------------------------------------------------=
------------------------
>
>                 Key: CASSANDRA-13963
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1396=
3
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Secondary Indexes, Testing
>            Reporter: Andr=C3=A9s de la Pe=C3=B1a
>            Assignee: Andr=C3=A9s de la Pe=C3=B1a
>            Priority: Minor
>             Fix For: 4.x
>
>
> The unit test [SecondaryIndexManagerTest.indexWithfailedInitializationIsN=
otQueryableAfterPartialRebuild|https://github.com/apache/cassandra/blob/tru=
nk/test/unit/org/apache/cassandra/index/SecondaryIndexManagerTest.java#L460=
-L476] is flaky. Apart from [the CI results showing a 3% flakiness|http://c=
assci.datastax.com/view/All_Jobs/job/trunk_utest/2430/testReport/org.apache=
.cassandra.index/SecondaryIndexManagerTest/indexWithfailedInitializationIsN=
otQueryableAfterPartialRebuild/], the test failure can be locally reproduce=
d just running the test multiple times. In my case, it fails 2-5 times for =
each 1000 executions.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org