Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 17 Oct 2017 08:20:00 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13097898.1503905140000.14434.1508228400448@Atlassian.JIRA>
In-Reply-To: <JIRA.13097898.1503905140000@Atlassian.JIRA>
References: <JIRA.13097898.1503905140000@Atlassian.JIRA> <JIRA.13097898.1503905140097@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CASSANDRA-13813) Don't let user drop (or
 generally break) tables in system_distributed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 17 Oct 2017 08:20:05 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207161#comment-16207161 ] 

Sylvain Lebresne commented on CASSANDRA-13813:
----------------------------------------------

As suggested earlier, I'm personally +1 on the patch here now that we have CASSANDRA-13954.

> Don't let user drop (or generally break) tables in system_distributed
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-13813
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13813
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Distributed Metadata
>            Reporter: Sylvain Lebresne
>            Assignee: Aleksey Yeschenko
>             Fix For: 3.0.x, 3.11.x
>
>
> There is not currently no particular restrictions on schema modifications to tables of the {{system_distributed}} keyspace. This does mean you can drop those tables, or even alter them in wrong ways like dropping or renaming columns. All of which is guaranteed to break stuffs (that is, repair if you mess up with on of it's table, or MVs if you mess up with {{view_build_status}}).
> I'm pretty sure this was never intended and is an oversight of the condition on {{ALTERABLE_SYSTEM_KEYSPACES}} in [ClientState|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/ClientState.java#L397]. That condition is such that any keyspace not listed in {{ALTERABLE_SYSTEM_KEYSPACES}} (which happens to be the case for {{system_distributed}}) has no specific restrictions whatsoever, while given the naming it's fair to assume the intention that exactly the opposite.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org