cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-13930) Avoid grabbing the read lock when checking if compaction strategy should do defragmentation
Date Sat, 07 Oct 2017 15:49:02 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195593#comment-16195593
] 

Jeff Jirsa edited comment on CASSANDRA-13930 at 10/7/17 3:48 PM:
-----------------------------------------------------------------

Patch looks good. Dtests look good, -circleci won’t load for me- circle looks good. 

What do you think about a similar fix for fanout? Maybe not worth the effort, since it's not
in as hot of a path, and it's more likely to change than defrag? 

+1 to commit 


was (Author: jjirsa):
Patch looks good. Dtests look good, circleci won’t load for me

What do you think about a similar fix for fanout? 

+1 to commit if you’re happy with CI

> Avoid grabbing the read lock when checking if compaction strategy should do defragmentation
> -------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13930
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13930
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.11.x, 4.x
>
>
> We grab the read lock when checking whether the compaction strategy benefits from defragmentation,
avoid that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message