cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-13922) nodetool verify should also verify sstable metadata
Date Tue, 03 Oct 2017 15:42:01 GMT


Jason Brown commented on CASSANDRA-13922:

On the whole this patch looks fine. I have some petty nits are ones beyond what you changed
in this patch (just general code clean up), so feel free to ignore or change on commit:

- remove dead imports like {{FBUtilities}} (in 3.0 branch)
- remove dead field {{badRows}} - not sure what it's original use was.
- add a comment to li. 208 {{UnfilteredRowIterator iterator}} that the variable is intentionally

Also, and this was there from before, if {{markAndThrow}} fails on {{mutateRepairedAt}}, we'll
percolate that error, rather than the {{CorruptSSTableException}} that it is coded to do.
If you feel it's warranted, maybe add a try-catch block around the {{mutateRepairedAt}}, log
that error if one occurs, and still throw the original {{CorruptSSTableException}}. 

Either way, I'm +1.

Thanks for adding a test in {{VerifyTest}} - saves me from concating a one-off test to verify
this patch ;)

> nodetool verify should also verify sstable metadata
> ---------------------------------------------------
>                 Key: CASSANDRA-13922
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.0.x, 3.11.x, 4.x
> nodetool verify should also try to deserialize the sstable metadata (and once CASSANDRA-13321
makes it in, verify the checksums)

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message