Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 29 Sep 2017 17:06:00 +0000 (UTC)
From: "Ariel Weisberg (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13105265.1506469094000.237741.1506704760660@Atlassian.JIRA>
In-Reply-To: <JIRA.13105265.1506469094000@Atlassian.JIRA>
References: <JIRA.13105265.1506469094000@Atlassian.JIRA> <JIRA.13105265.1506469094095@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (CASSANDRA-13906) Properly close
 StreamCompressionInputStream to release any ByteBuf
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 29 Sep 2017 17:06:04 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186087#comment-16186087 ] 

Ariel Weisberg edited comment on CASSANDRA-13906 at 9/29/17 5:05 PM:
---------------------------------------------------------------------

If you implement Closable it's going to cause warnings any place that doesn't use try with resources. Given the other usages I think what you have done is probably fine although you can still switch to try with resources just for {{StreamCompressionInputStream}}.


was (Author: aweisberg):
If you implement Closable it's going to cause warnings any place that doesn't use try with resources. Given the other usages I think what you have done is probably fine although you can still switch to try with resources.

> Properly close StreamCompressionInputStream to release any ByteBuf
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-13906
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13906
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>
> When running dtests for trunk (4.x) that perform some streaming, sometimes a {{ByteBuf}} is not released properly, and we get this error in the logs (causing the dtest to fail):
> {code}
> ERROR [MessagingService-NettyOutbound-Thread-4-2] 2017-09-26 13:42:37,940 Slf4JLogger.java:176 - LEAK: ByteBuf.release() was not called before it's garbage-collected. Enable advanced leak reporting to find out where the leak occurred. To enable advanced leak reporting, specify the JVM option '-Dio.netty.leakDetection.level=advanced' or call ResourceLeakDetector.setLevel() See http://netty.io/wiki/reference-counted-objects.html for more information.
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org