Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1B586200CFD for ; Wed, 6 Sep 2017 18:53:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 19EB71609BB; Wed, 6 Sep 2017 16:53:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 62F201609D1 for ; Wed, 6 Sep 2017 18:53:05 +0200 (CEST) Received: (qmail 13413 invoked by uid 500); 6 Sep 2017 16:53:04 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 13396 invoked by uid 99); 6 Sep 2017 16:53:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Sep 2017 16:53:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0FF0BD6FEC for ; Wed, 6 Sep 2017 16:53:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KSfNZaGNRCyJ for ; Wed, 6 Sep 2017 16:53:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A24FA6103E for ; Wed, 6 Sep 2017 16:53:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 570B8E0EF5 for ; Wed, 6 Sep 2017 16:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 860282415D for ; Wed, 6 Sep 2017 16:53:00 +0000 (UTC) Date: Wed, 6 Sep 2017 16:53:00 +0000 (UTC) From: "Branimir Lambov (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-13703) Using min_compress_ratio <= 1 causes corruption MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 06 Sep 2017 16:53:06 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155665#comment-16155665 ] Branimir Lambov commented on CASSANDRA-13703: --------------------------------------------- Rebased and updated the branch, reducing the visibility of {{shouldCheckCrc}} and adding a comment and {{VisibleForTesting}} annotations to make it clear why the shorthand methods use inconsistent parameters. > Using min_compress_ratio <= 1 causes corruption > ----------------------------------------------- > > Key: CASSANDRA-13703 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13703 > Project: Cassandra > Issue Type: Bug > Reporter: Branimir Lambov > Assignee: Branimir Lambov > Priority: Blocker > Fix For: 4.x > > Attachments: patch > > > This is because chunks written uncompressed end up below the compressed size threshold. Demonstrated by applying the attached patch meant to improve the testing of the 10520 changes, and running {{CompressedSequentialWriterTest.testLZ4Writer}}. > The default {{min_compress_ratio: 0}} is not affected as it never writes uncompressed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org