Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 29 Sep 2017 19:22:00 +0000 (UTC)
From: "Aleksey Yeschenko (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13079423.1497345632000.238938.1506712920558@Atlassian.JIRA>
In-Reply-To: <JIRA.13079423.1497345632000@Atlassian.JIRA>
References: <JIRA.13079423.1497345632000@Atlassian.JIRA> <JIRA.13079423.1497345632903@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CASSANDRA-13595) Implement short read
 protection on partition boundaries
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 29 Sep 2017 19:22:07 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-13595?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D16186272#comment-16186272 ]=20

Aleksey Yeschenko commented on CASSANDRA-13595:
-----------------------------------------------

Thanks. Squashed the last to commits together, will commit once CI is happy=
.

> Implement short read protection on partition boundaries
> -------------------------------------------------------
>
>                 Key: CASSANDRA-13595
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1359=
5
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination
>            Reporter: Andr=C3=A9s de la Pe=C3=B1a
>            Assignee: Aleksey Yeschenko
>              Labels: Correctness
>             Fix For: 3.0.15, 3.11.1
>
>
> It seems that short read protection doesn't work when the short read is d=
one at the end of a partition in a range query. The final assertion of this=
 dtest fails:
> {code}
> def short_read_partitions_delete_test(self):
>         cluster =3D self.cluster
>         cluster.set_configuration_options(values=3D{'hinted_handoff_enabl=
ed': False})
>         cluster.set_batch_commitlog(enabled=3DTrue)
>         cluster.populate(2).start(wait_other_notice=3DTrue)
>         node1, node2 =3D self.cluster.nodelist()
>         session =3D self.patient_cql_connection(node1)
>         create_ks(session, 'ks', 2)
>         session.execute("CREATE TABLE t (k int, c int, PRIMARY KEY(k, c))=
 WITH read_repair_chance =3D 0.0")
>         # we write 1 and 2 in a partition: all nodes get it.
>         session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, =
1)", consistency_level=3DConsistencyLevel.ALL))
>         session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (2, =
1)", consistency_level=3DConsistencyLevel.ALL))
>         # we delete partition 1: only node 1 gets it.
>         node2.flush()
>         node2.stop(wait_other_notice=3DTrue)
>         session =3D self.patient_cql_connection(node1, 'ks', consistency_=
level=3DConsistencyLevel.ONE)
>         session.execute(SimpleStatement("DELETE FROM t WHERE k =3D 1"))
>         node2.start(wait_other_notice=3DTrue)
>         # we delete partition 2: only node 2 gets it.
>         node1.flush()
>         node1.stop(wait_other_notice=3DTrue)
>         session =3D self.patient_cql_connection(node2, 'ks', consistency_=
level=3DConsistencyLevel.ONE)
>         session.execute(SimpleStatement("DELETE FROM t WHERE k =3D 2"))
>         node1.start(wait_other_notice=3DTrue)
>         # read from both nodes
>         session =3D self.patient_cql_connection(node1, 'ks', consistency_=
level=3DConsistencyLevel.ALL)
>         assert_none(session, "SELECT * FROM t LIMIT 1")
> {code}
> However, the dtest passes if we remove the {{LIMIT 1}}.
> Short read protection [uses a {{SinglePartitionReadCommand}}|https://gith=
ub.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/Da=
taResolver.java#L484], maybe it should use a {{PartitionRangeReadCommand}} =
instead?


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org