Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 28 Sep 2017 11:26:00 +0000 (UTC)
From: "Jason Brown (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13047823.1488492284000.224820.1506597960891@Atlassian.JIRA>
In-Reply-To: <JIRA.13047823.1488492284000@Atlassian.JIRA>
References: <JIRA.13047823.1488492284000@Atlassian.JIRA> <JIRA.13047823.1488492284830@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CASSANDRA-13291) Replace usages of
 MessageDigest with Guava's Hasher
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 28 Sep 2017 11:26:06 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184029#comment-16184029 ] 

Jason Brown commented on CASSANDRA-13291:
-----------------------------------------

I'm +1 on the code. [~mkjellman] wdyt about including the microbenchmark I put together?

> Replace usages of MessageDigest with Guava's Hasher
> ---------------------------------------------------
>
>                 Key: CASSANDRA-13291
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13291
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Michael Kjellman
>            Assignee: Michael Kjellman
>         Attachments: CASSANDRA-13291-trunk.diff
>
>
> During my profiling of C* I frequently see lots of aggregate time across threads being spent inside the MD5 MessageDigest implementation. Given that there are tons of modern alternative hashing functions better than MD5 available -- both in terms of providing better collision resistance and actual computational speed -- I wanted to switch out our usage of MD5 for alternatives (like adler128 or murmur3_128) and test for performance improvements.
> Unfortunately, I found given the fact we use MessageDigest everywhere --  switching out the hashing function to something like adler128 or murmur3_128 (for example) -- which don't ship with the JDK --  wasn't straight forward.
> The goal of this ticket is to propose switching out usages of MessageDigest directly in favor of Hasher from Guava. This means going forward we can change a single line of code to switch the hashing algorithm being used (assuming there is an implementation in Guava).


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org