cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-13914) Advertise RPC_READY for both native protocol and Thrift
Date Wed, 27 Sep 2017 20:43:00 GMT
Aleksey Yeschenko created CASSANDRA-13914:
---------------------------------------------

             Summary: Advertise RPC_READY for both native protocol and Thrift
                 Key: CASSANDRA-13914
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13914
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Aleksey Yeschenko
            Assignee: Aleksey Yeschenko
            Priority: Minor
             Fix For: 3.0.x, 3.11.x


This is a follow-up JIRA to CASSANDRA-13043.

To quote my concerns and [~slebresne]'s from that JIRA:

{quote}
Other than that, I agree with you concern. If we want to stick with the current approach at
least as far 3.x goes for simplicity, then maybe we can simply advertise rpc-ready at the
end of {{CassandraDaemon.start}} but in all case? In fact, I'm not sure why we only set it
for the native protocol, and that might simply be an oversight. At the very least, thrift
is literally referred to "rpc" in the yaml, so not setting {{RPC_READY}} for it feels wrong.
And going a step further, if you have explicitly asked to not start any of the client server,
then it wouldn't be a lie to set {{RPC_READY}} at the end of start() in the sense of "every
RPC servers you asked us to start is ready". Anyway, maybe someone rely on this being only
set for the native protocol, I genuinely have no clue.
{quote}

If we don't correct this, then at least Thrift-only users of 3.0.x (are there any?) and those
who use storage-only-nodes and coordinator-only-nodes wouldn't be happy after upgrading to
3.0.15 - counters won't properly work anymore.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message