cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitar Dimitrov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-13692) CompactionAwareWriter_getWriteDirectory throws incompatible exceptions
Date Thu, 14 Sep 2017 11:30:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150212#comment-16150212
] 

Dimitar Dimitrov edited comment on CASSANDRA-13692 at 9/14/17 11:29 AM:
------------------------------------------------------------------------

Okay, here are the branches with the proposed changes:

| [2.2|https://github.com/apache/cassandra/compare/cassandra-2.2...dimitarndimitrov:c13692-2.2]
| [testall|^c13692-2.2-testall-results.PNG] | [dtest|^c13692-2.2-dtest-results.PNG] ([dtest-baseline|https://cassci.datastax.com/job/cassandra-2.2_dtest/lastCompletedBuild/testReport/])
|
| [3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...dimitarndimitrov:c13692-3.0]
| [testall|^c13692-3.0-testall-results.PNG] | [dtest|^c13692-3.0-dtest-results.PNG] ([dtest-baseline|https://cassci.datastax.com/job/cassandra-3.0_dtest/lastCompletedBuild/testReport/])
|
| [3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...dimitarndimitrov:c13692-3.11]
| [testall|^c13692-3.11-testall-results.PNG] ([testall-baseline|https://cassci.datastax.com/job/cassandra-3.11_testall/lastCompletedBuild/testReport/])
| [dtest|^c13692-3.11-dtest-results.PNG] ([dtest-baseline|https://cassci.datastax.com/job/cassandra-3.11_dtest/lastCompletedBuild/testReport/])
|
| [trunk|https://github.com/apache/cassandra/compare/trunk...dimitarndimitrov:c13692] | [testall|^c13692-testall-results.PNG]
| [dtest|^c13692-dtest-results.PNG] ([dtest-baseline|https://cassci.datastax.com/job/trunk_dtest/lastCompletedBuild/testReport/])
|

testall results look good for all branches, but there's a common theme of {{consistency_test.TestConsistency.test_13747}}
dtests failing, in addition to the common-expected-to-be-unrelated dtest failures.
My assumption is that this is related to CASSANDRA-13747 (the comments there seem to corroborate
that).

[~iamaleksey], do you have an idea if that could be the case?


was (Author: dimitarndimitrov):
Okay, here are the branches with the proposed changes:

| [2.2|https://github.com/apache/cassandra/compare/cassandra-2.2...dimitarndimitrov:c13692-2.2]
| [testall|^c13692-2.2-testall-results.PNG] | [dtest|^c13692-2.2-dtest-results.PNG] ([dtest-baseline|https://cassci.datastax.com/job/cassandra-2.2_dtest/lastCompletedBuild/testReport/])
|
| [3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...dimitarndimitrov:c13692-3.0]
| [testall|^c13692-3.0-testall-results.PNG] | [dtest|^c13692-3.0-dtest-results.PNG] ([dtest-baseline|https://cassci.datastax.com/job/cassandra-3.0_dtest/lastCompletedBuild/testReport/])
|
| [3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...dimitarndimitrov:c13692-3.11]
| [testall|^c13692-3.11-testall-results.PNG] ([testall-baseline|https://cassci.datastax.com/job/cassandra-3.11_testall/lastCompletedBuild/testReport/])
| [dtest|^c13692-3.11-dtest-results.PNG] ([dtest-baseline|https://cassci.datastax.com/job/cassandra-3.11_dtest/lastCompletedBuild/testReport/])
|
| [trunk|https://github.com/apache/cassandra/compare/trunk...dimitarndimitrov:c13692] | [testall|^c13692-testall-results.PNG]
| [dtest|^c13692-dtest-results.PNG] ([dtest-baseline|https://cassci.datastax.com/job/trunk_dtest/lastCompletedBuild/testReport/])
|

{{testall}} results look good for all branches, but there's a common theme of consistency_test.TestConsistency.test_13747
dtests failing, in addition to the common-expected-to-be-unrelated {{dtest}} failures.
My assumption is that this is related to CASSANDRA-13747 (the comments there seem to corroborate
that).

[~iamaleksey], do you have an idea if that could be the case?

> CompactionAwareWriter_getWriteDirectory throws incompatible exceptions
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-13692
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13692
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Hao Zhong
>            Assignee: Dimitar Dimitrov
>              Labels: lhf
>         Attachments: c13692-2.2-dtest-results.PNG, c13692-2.2-testall-results.PNG, c13692-3.0-dtest-results.PNG,
c13692-3.0-dtest-results-updated.PNG, c13692-3.0-testall-results.PNG, c13692-3.11-dtest-results.PNG,
c13692-3.11-dtest-results-updated.PNG, c13692-3.11-testall-results.PNG, c13692-dtest-results.PNG,
c13692-dtest-results-updated.PNG, c13692-testall-results.PNG
>
>
> The CompactionAwareWriter_getWriteDirectory throws RuntimeException:
> {code}
> public Directories.DataDirectory getWriteDirectory(Iterable<SSTableReader> sstables,
long estimatedWriteSize)
>     {
>         File directory = null;
>         for (SSTableReader sstable : sstables)
>         {
>             if (directory == null)
>                 directory = sstable.descriptor.directory;
>             if (!directory.equals(sstable.descriptor.directory))
>             {
>                 logger.trace("All sstables not from the same disk - putting results in
{}", directory);
>                 break;
>             }
>         }
>         Directories.DataDirectory d = getDirectories().getDataDirectoryForFile(directory);
>         if (d != null)
>         {
>             long availableSpace = d.getAvailableSpace();
>             if (availableSpace < estimatedWriteSize)
>                 throw new RuntimeException(String.format("Not enough space to write %s
to %s (%s available)",
>                                                          FBUtilities.prettyPrintMemory(estimatedWriteSize),
>                                                          d.location,
>                                                          FBUtilities.prettyPrintMemory(availableSpace)));
>             logger.trace("putting compaction results in {}", directory);
>             return d;
>         }
>         d = getDirectories().getWriteableLocation(estimatedWriteSize);
>         if (d == null)
>             throw new RuntimeException(String.format("Not enough disk space to store
%s",
>                                                      FBUtilities.prettyPrintMemory(estimatedWriteSize)));
>         return d;
>     }
> {code}
> However, the thrown exception does not  trigger the failure policy. CASSANDRA-11448 fixed
a similar problem. The buggy code is:
> {code}
> protected Directories.DataDirectory getWriteDirectory(long writeSize)
>     {
>         Directories.DataDirectory directory = getDirectories().getWriteableLocation(writeSize);
>         if (directory == null)
>             throw new RuntimeException("Insufficient disk space to write " + writeSize
+ " bytes");
>         return directory;
>     }
> {code}
> The fixed code is:
> {code}
> protected Directories.DataDirectory getWriteDirectory(long writeSize)
>     {
>         Directories.DataDirectory directory = getDirectories().getWriteableLocation(writeSize);
>         if (directory == null)
>             throw new FSWriteError(new IOException("Insufficient disk space to write
" + writeSize + " bytes"), "");
>         return directory;
>     }
> {code}
> The fixed code throws FSWE and triggers the failure policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message