cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-13631) add header parameter size to internode messaging protocol
Date Tue, 19 Sep 2017 15:31:00 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Brown updated CASSANDRA-13631:
------------------------------------
    Fix Version/s: 4.0
           Status: Patch Available  (was: Open)

||13631||
|[branch|https://github.com/jasobrown/cassandra/tree/13631]|
|[dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/330/]|
|[utests|https://circleci.com/gh/jasobrown/cassandra/tree/13631]|


> add header parameter size to internode messaging protocol
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-13631
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13631
>             Project: Cassandra
>          Issue Type: Task
>          Components: Streaming and Messaging
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>             Fix For: 4.0
>
>
> as netty is not a streaming/blocking protocol and works best when buffer sizes are known,
I had to do a bunch of contortions in {{MessageInHandler}} (as part of CASSANDRA-8457) to
safely read the message header parameters. If we add a header parameters size field to the
internode messaging protocol, the header parsing code would be dramatically simpler (note:
we'll still need the existing parsing to support the cluster upgrade use case). An alternative
to adding a new field is to hijack the existing header parameter count field; that field is
an {{int}}, so field width is not an issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message