cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mck (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-13418) Allow TWCS to ignore overlaps when dropping fully expired sstables
Date Fri, 01 Sep 2017 12:16:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150409#comment-16150409
] 

mck edited comment on CASSANDRA-13418 at 9/1/17 12:15 PM:
----------------------------------------------------------

[~rgerard], i failed to see your last comment til now.
I've addressed [~krummas]'s concerns [here|https://github.com/thelastpickle/cassandra/commit/58440e707cd6490847a37dc8d76c150d3eb27aab],
but feel terrible now for stepping on your toes.

A few code style issues beyond the braces have been fixed. Thanks for the push back Marcus!
For example, I change the names of the constants in {{TimeWindowCompactionStrategyOptions}}
to be more in align with the previous constants there.

Two additions to the tests in {{TimeWindowCompactionStrategyTest}} are added. One for the
{{TimeWindowCompactionStrategyOptions.validateOptions}} which is only there for the tests,
and a new test method which does what Marcus asks for. ([~krummas], do you still want a dtest?)


was (Author: michaelsembwever):
[~rgerard], i failed to see your last comment til now.
I've addressed [~krummas]'s concerns [here|https://github.com/thelastpickle/cassandra/commit/17b1d30ac8f07c49bfc4d51b14d3201cc969fcfe],
but feel terrible now for stepping on your toes.

A few code style issues beyond the braces have been fixed. Thanks for the push back Marcus!
For example, I change the names of the constants in {{TimeWindowCompactionStrategyOptions}}
to be more in align with the previous constants there.

Two additions to the tests in {{TimeWindowCompactionStrategyTest}} are added. One for the
{{TimeWindowCompactionStrategyOptions.validateOptions}} which is only there for the tests,
and a new test method which does what Marcus asks for. ([~krummas], do you still want a dtest?)

> Allow TWCS to ignore overlaps when dropping fully expired sstables
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-13418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13418
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: Corentin Chary
>            Assignee: Romain GERARD
>              Labels: twcs
>         Attachments: twcs-cleanup.png
>
>
> http://thelastpickle.com/blog/2016/12/08/TWCS-part1.html explains it well. If you really
want read-repairs you're going to have sstables blocking the expiration of other fully expired
SSTables because they overlap.
> You can set unchecked_tombstone_compaction = true or tombstone_threshold to a very low
value and that will purge the blockers of old data that should already have expired, thus
removing the overlaps and allowing the other SSTables to expire.
> The thing is that this is rather CPU intensive and not optimal. If you have time series,
you might not care if all your data doesn't exactly expire at the right time, or if data re-appears
for some time, as long as it gets deleted as soon as it can. And in this situation I believe
it would be really beneficial to allow users to simply ignore overlapping SSTables when looking
for fully expired ones.
> To the question: why would you need read-repairs ?
> - Full repairs basically take longer than the TTL of the data on my dataset, so this
isn't really effective.
> - Even with a 10% chances of doing a repair, we found out that this would be enough to
greatly reduce entropy of the most used data (and if you have timeseries, you're likely to
have a dashboard doing the same important queries over and over again).
> - LOCAL_QUORUM is too expensive (need >3 replicas), QUORUM is too slow.
> I'll try to come up with a patch demonstrating how this would work, try it on our system
and report the effects.
> cc: [~adejanovski], [~rgerard] as I know you worked on similar issues already.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message