cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-13321) Add a checksum component for the sstable metadata (-Statistics.db) file
Date Fri, 29 Sep 2017 14:12:00 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-13321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Marcus Eriksson updated CASSANDRA-13321:
----------------------------------------
    Status: Patch Available  (was: Open)

I have rebased and fixed a few issues with the simpler solution (https://github.com/krummas/cassandra/commits/marcuse/appendedchecksum)
- I think we should go with that version for now as the swapping of sstable metadata seems
to be working (and this doesn't change that part at all)

https://circleci.com/gh/krummas/cassandra/125
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/350/

Note that the checksumming is a bit awkward since I didn't want to add a length before each
metadata component, instead everything is hashed as it is being read. With sstable metadata,
we could probably do that and verify the actual bytes instead - this is something you could
consider during review

> Add a checksum component for the sstable metadata (-Statistics.db) file
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-13321
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13321
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 4.x
>
>
> Since we keep important information in the sstable metadata file now, we should add a
checksum component for it. One danger being if a bit gets flipped in repairedAt we could consider
the sstable repaired when it is not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message