cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Podkowinski (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-13263) Incorrect ComplexColumnData hashCode implementation
Date Tue, 05 Sep 2017 11:05:00 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stefan Podkowinski updated CASSANDRA-13263:
-------------------------------------------
       Resolution: Fixed
    Fix Version/s: 4.0
                   3.11.1
                   3.0.15
           Status: Resolved  (was: Patch Available)

I'm pretty sure that fixing a hashCode function that isn't even used yet will cause much harm.
Merged as 1e80e35 for 3.0 upwards with your suggested changes. Thanks for reviewing.

> Incorrect ComplexColumnData hashCode implementation
> ---------------------------------------------------
>
>                 Key: CASSANDRA-13263
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13263
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stefan Podkowinski
>            Assignee: Stefan Podkowinski
>             Fix For: 3.0.15, 3.11.1, 4.0
>
>
> I went through some of the logs from CASSANDRA-13175 and one of the more serious issues
that we should address seem to be the {{ComplexColumnData.hashCode()}} implementation. As
Objects.hashCode is not using deep hashing for array arguments, hashed will be based on the
identity instead of the array's content. See patch for simple fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message