cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-13175) Integrate "Error Prone" Code Analyzer
Date Fri, 08 Sep 2017 11:05:02 GMT


Marcus Eriksson commented on CASSANDRA-13175:

oh, missed that. We'll need the circle.yml fix anyway

Should we upgrade guava perhaps? (in a separate ticket)

> Integrate "Error Prone" Code Analyzer
> -------------------------------------
>                 Key: CASSANDRA-13175
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stefan Podkowinski
>            Assignee: Stefan Podkowinski
>         Attachments: 0001-Add-Error-Prone-code-analyzer.patch, checks-2_2.out, checks-3_0.out,
> I've been playing with [Error Prone|] by integrating it into the
build process and to see what kind of warnings it would produce. So far I'm positively impressed
by the coverage and usefulness of some of the implemented checks. See attachments for results.
> Unfortunately there are still some issues on how the analyzer is effecting generated
code and used guava versions, see [#492|].
In case those issues have been solved and the resulting code isn't affected by the analyzer,
I'd suggest to add it to trunk with warn only behaviour and some less useful checks disabled.
Alternatively a new ant target could be added, maybe with build breaking checks and CI integration.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message