cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-13069) Local batchlog for MV may not be correctly written on node movements
Date Tue, 12 Sep 2017 13:41:00 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-13069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paulo Motta updated CASSANDRA-13069:
------------------------------------
       Resolution: Fixed
    Fix Version/s: 4.0
                   3.11.1
                   3.0.15
           Status: Resolved  (was: Patch Available)

bq. Lgtm, +1 if CI is happy (or at least as happy as it usually is).

CI look good, committed as {{12103653f313d6f1ef030a535986123ddcffea9c}} to cassandra-3.0 and
merge up to cassandra-3.11 and master. Dtests merged to cassandra-dtest master as {{c39a85c3e7b2869ef3fffafe1380362d6469919d}}.

Thanks for the review!

> Local batchlog for MV may not be correctly written on node movements
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-13069
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13069
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Materialized Views
>            Reporter: Sylvain Lebresne
>            Assignee: Paulo Motta
>             Fix For: 3.0.15, 3.11.1, 4.0
>
>
> Unless I'm really reading this wrong, I think the code [here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/StorageProxy.java#L829-L843],
which comes from CASSANDRA-10674, isn't working properly.
> More precisely, I believe we can have both paired and unpaired mutations, so that both
{{if}} can be taken, but if that's the case, the 2nd write to the batchlog will basically
overwrite (remove) the batchlog write of the 1st {{if}} and I don't think that's the intention.
In practice, this means "paired" mutation won't be in the batchlog, which mean they won't
be replayed at all if they fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message