Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 39DC6200CE0 for ; Fri, 25 Aug 2017 13:35:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3665216C814; Fri, 25 Aug 2017 11:35:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7ABBA16C810 for ; Fri, 25 Aug 2017 13:35:12 +0200 (CEST) Received: (qmail 82063 invoked by uid 500); 25 Aug 2017 11:35:06 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 82048 invoked by uid 99); 25 Aug 2017 11:35:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Aug 2017 11:35:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E8A17C1339 for ; Fri, 25 Aug 2017 11:35:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 9H8IWl4DB0zT for ; Fri, 25 Aug 2017 11:35:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4905761E29 for ; Fri, 25 Aug 2017 11:35:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BF704E08B4 for ; Fri, 25 Aug 2017 11:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 34E2F25381 for ; Fri, 25 Aug 2017 11:35:00 +0000 (UTC) Date: Fri, 25 Aug 2017 11:35:00 +0000 (UTC) From: "ZhaoYang (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CASSANDRA-13798) Disallow filtering on non-primary-key base column for MV MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 25 Aug 2017 11:35:13 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141491#comment-16141491 ] ZhaoYang edited comment on CASSANDRA-13798 at 8/25/17 11:34 AM: ---------------------------------------------------------------- | [trunk|https://github.com/jasonstack/cassandra/commits/CASSANDRA-13798-trunk] | | [3.11|https://github.com/jasonstack/cassandra/commits/CASSANDRA-13798-3.11] | | [dtest|https://github.com/riptano/cassandra-dtest/commits/CASSANDRA-13798] | The patch is to revert supporting non-pk base column filtering on MV on 3.11 & trunk. The feature was added in 3.10 and the consequence may have been overlooked. It's better to revert it in 3.x/trunk, before more users start using it. At the same time, I will work on a proper design (eg. multi-timestamp approach discussed in CASSANDRA-11500 and CASSANDRA-10226) for non-pk base column filtering and multiple non-pk base column in view pk. [~pauloricardomg] [~brstgt] [~KurtG] what do you think? was (Author: jasonstack): | [trunk|https://github.com/jasonstack/cassandra/commits/CASSANDRA-13798-trunk] | | [3.11|https://github.com/jasonstack/cassandra/commits/CASSANDRA-13798-3.11] | | [dtest|https://github.com/riptano/cassandra-dtest/commits/CASSANDRA-13798] | The patch is to revert supporting non-pk base column filtering on MV on 3.11 & trunk. The feature was added in 3.10 and the consequence may have been overlooked. It's better to revert it in 3.x/trunk, before more users start using it. At the same time, I will work on a proper design (eg. multi-timestamp approach discussed in CASSANDRA-11500 and CASSANDRA-10226) for non-pk base column filtering and multiple non-pk base column in view pk. > Disallow filtering on non-primary-key base column for MV > -------------------------------------------------------- > > Key: CASSANDRA-13798 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13798 > Project: Cassandra > Issue Type: Bug > Components: Materialized Views > Reporter: ZhaoYang > Assignee: ZhaoYang > > We should probably consider disallow filtering conditions on non-primary-key base column for Materialized View which is introduced in CASSANDRA-10368. > The main problem is that the liveness of view row is now depending on multiple base columns (multiple filtered non-pk base column + base column used in view pk) and this semantic could not be properly support without drastic storage format changes. (SEE CASSANDRA-11500, [background|https://issues.apache.org/jira/browse/CASSANDRA-11500?focusedCommentId=16119823&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16119823]) > We should step back and re-consider the non-primary-key filtering feature together with supporting multiple non-PK cols in MV clustering key in CASSANDRA-10226. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org