Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 29 Aug 2017 19:54:00 +0000 (UTC)
From: "Dimitar Dimitrov (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13087106.1500017376000.151375.1504036440117@Atlassian.JIRA>
In-Reply-To: <JIRA.13087106.1500017376000@Atlassian.JIRA>
References: <JIRA.13087106.1500017376000@Atlassian.JIRA> <JIRA.13087106.1500017376547@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CASSANDRA-13692)
 CompactionAwareWriter_getWriteDirectory throws incompatible exceptions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 29 Aug 2017 19:54:06 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146000#comment-16146000 ] 

Dimitar Dimitrov commented on CASSANDRA-13692:
----------------------------------------------

Sorry for the late promised update.
I'm currently finalizing the test, which is a bit of a mix between {{OutOfSpaceTest}}, {{CompactionAwareWriterTest}}, and {{CompactionsBytemanTest}}.

I reckon that (1) the {{OutOfSpaceTest}}s approach translates well enough for checking whether failure policies are correctly triggered in this case; (2) the trickiest part (for me) would be to figure out whether the way {{CompactionAwareWriter#getWriteDirectory(Iterable<SSTableReader>, long)}} gets reached and executed, is correct and relevant.

> CompactionAwareWriter_getWriteDirectory throws incompatible exceptions
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-13692
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13692
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Hao Zhong
>            Assignee: Dimitar Dimitrov
>              Labels: lhf
>
> The CompactionAwareWriter_getWriteDirectory throws RuntimeException:
> {code}
> public Directories.DataDirectory getWriteDirectory(Iterable<SSTableReader> sstables, long estimatedWriteSize)
>     {
>         File directory = null;
>         for (SSTableReader sstable : sstables)
>         {
>             if (directory == null)
>                 directory = sstable.descriptor.directory;
>             if (!directory.equals(sstable.descriptor.directory))
>             {
>                 logger.trace("All sstables not from the same disk - putting results in {}", directory);
>                 break;
>             }
>         }
>         Directories.DataDirectory d = getDirectories().getDataDirectoryForFile(directory);
>         if (d != null)
>         {
>             long availableSpace = d.getAvailableSpace();
>             if (availableSpace < estimatedWriteSize)
>                 throw new RuntimeException(String.format("Not enough space to write %s to %s (%s available)",
>                                                          FBUtilities.prettyPrintMemory(estimatedWriteSize),
>                                                          d.location,
>                                                          FBUtilities.prettyPrintMemory(availableSpace)));
>             logger.trace("putting compaction results in {}", directory);
>             return d;
>         }
>         d = getDirectories().getWriteableLocation(estimatedWriteSize);
>         if (d == null)
>             throw new RuntimeException(String.format("Not enough disk space to store %s",
>                                                      FBUtilities.prettyPrintMemory(estimatedWriteSize)));
>         return d;
>     }
> {code}
> However, the thrown exception does not  trigger the failure policy. CASSANDRA-11448 fixed a similar problem. The buggy code is:
> {code}
> protected Directories.DataDirectory getWriteDirectory(long writeSize)
>     {
>         Directories.DataDirectory directory = getDirectories().getWriteableLocation(writeSize);
>         if (directory == null)
>             throw new RuntimeException("Insufficient disk space to write " + writeSize + " bytes");
>         return directory;
>     }
> {code}
> The fixed code is:
> {code}
> protected Directories.DataDirectory getWriteDirectory(long writeSize)
>     {
>         Directories.DataDirectory directory = getDirectories().getWriteableLocation(writeSize);
>         if (directory == null)
>             throw new FSWriteError(new IOException("Insufficient disk space to write " + writeSize + " bytes"), "");
>         return directory;
>     }
> {code}
> The fixed code throws FSWE and triggers the failure policy.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org