Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sun, 27 Aug 2017 20:02:01 +0000 (UTC)
From: "Jeff Jirsa (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13039469.1485957256000.131776.1503864121593@Atlassian.JIRA>
In-Reply-To: <JIRA.13039469.1485957256000@Atlassian.JIRA>
References: <JIRA.13039469.1485957256000@Atlassian.JIRA> <JIRA.13039469.1485957256163@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CASSANDRA-13175) Integrate "Error Prone" Code
 Analyzer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 27 Aug 2017 20:02:07 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143205#comment-16143205 ] 

Jeff Jirsa commented on CASSANDRA-13175:
----------------------------------------

[~aweisberg] and [~krummas] have been looking at CI for the project recently, perhaps this is interesting enough to one of them to review.


> Integrate "Error Prone" Code Analyzer
> -------------------------------------
>
>                 Key: CASSANDRA-13175
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13175
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stefan Podkowinski
>            Assignee: Stefan Podkowinski
>         Attachments: 0001-Add-Error-Prone-code-analyzer.patch, checks-2_2.out, checks-3_0.out, checks-trunk.out
>
>
> I've been playing with [Error Prone|http://errorprone.info/] by integrating it into the build process and to see what kind of warnings it would produce. So far I'm positively impressed by the coverage and usefulness of some of the implemented checks. See attachments for results.
> Unfortunately there are still some issues on how the analyzer is effecting generated code and used guava versions, see [#492|https://github.com/google/error-prone/issues/492]. In case those issues have been solved and the resulting code isn't affected by the analyzer, I'd suggest to add it to trunk with warn only behaviour and some less useful checks disabled. Alternatively a new ant target could be added, maybe with build breaking checks and CI integration.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org