cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13772) Add a skip read validation flag to cassandra-stress
Date Thu, 24 Aug 2017 17:54:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140404#comment-16140404
] 

Jason Brown commented on CASSANDRA-13772:
-----------------------------------------

The patch as submitted was largely fine, except for the fact that it didn't actually work.
[~noam@scylladb.com] forgot just one line in the submission, the one that hooks it up in {{SettingsErrors}}:

{code}
-            return Arrays.asList(retries, ignore);
+            return Arrays.asList(retries, ignore, skipReadValidation);
{code}

Other than that, I'm +1. Will commit shortly. 

> Add a skip read validation flag to cassandra-stress
> ---------------------------------------------------
>
>                 Key: CASSANDRA-13772
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13772
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Stress
>            Reporter: Noam Hasson
>            Assignee: Noam Hasson
>            Priority: Minor
>             Fix For: 3.11.x
>
>         Attachments: 13772-trunk.txt
>
>
> When running cassandra-stress with read operations, you must make sure all the data was
populated beforehand or else you will get the following errors:
> java.io.IOException: Operation x0 on key(s) [4d31314e32314b395030]: Data returned was
not validated
> 	at org.apache.cassandra.stress.Operation.error(Operation.java:127)
> 	at org.apache.cassandra.stress.Operation.timeWithRetry(Operation.java:105)
> 	at org.apache.cassandra.stress.operations.predefined.CqlOperation.run(CqlOperation.java:91)
> 	at org.apache.cassandra.stress.operations.predefined.CqlOperation.run(CqlOperation.java:99)
> 	at org.apache.cassandra.stress.operations.predefined.CqlOperation.run(CqlOperation.java:245)
> 	at org.apache.cassandra.stress.StressAction$Consumer.run(StressAction.java:453)
> java.lang.RuntimeException: Failed to execute warmup
> 	at org.apache.cassandra.stress.StressAction.warmup(StressAction.java:117)
> 	at org.apache.cassandra.stress.StressAction.run(StressAction.java:62)
> 	at org.apache.cassandra.stress.Stress.run(Stress.java:143)
> 	at org.apache.cassandra.stress.Stress.main(Stress.java:62)
> Even if you use the "-errors ignore" flag you'll get a lot of the following messages
which will both slow the stress and prevent it from displaying the metrics:
> Operation x0 on key(s) [4b3539393831374e3431]: Data returned was not validated
> Operation x0 on key(s) [4f4b3936363233375030]: Data returned was not validated
> Operation x0 on key(s) [4d304c4b32384f4b3031]: Data returned was not validated
> What I propose is to add a flag to skip the read validation, such as:
> -errors skip-read-validations
> This way when needed you can run a mixed workload and ignore validation of unpopulated
data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message