cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13751) Race / ref leak in PendingRepairManager
Date Wed, 09 Aug 2017 08:03:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119544#comment-16119544
] 

Marcus Eriksson commented on CASSANDRA-13751:
---------------------------------------------

+1 if tests succeed (seems the utests failed as well)

> Race / ref leak in PendingRepairManager
> ---------------------------------------
>
>                 Key: CASSANDRA-13751
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13751
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 4.0
>
>
> PendingRepairManager#getScanners has an assertion that confirms an sstable is, in fact,
marked as pending repair. Since validation compactions don't use the same concurrency controls
as proper compactions, they can race with promotion/demotion compactions and end up getting
assertion errors when the pending repair id is changed while the scanners are being acquired.
Also, error handling in PendingRepairManager and CompactionStrategyManager leaks refs when
this happens.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message