cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
Date Thu, 17 Aug 2017 23:30:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131474#comment-16131474
] 

Jeff Jirsa commented on CASSANDRA-13728:
----------------------------------------

I'm not [~jasobrown] , but I do have an opinion that we shouldn't change output of existing
JMX endpoints in minor versions, as people may be parsing it with tools and relying on its
output not changing. We should treat it as a public API, and not break it on a minor.

Would be better (in my opinion) to use {{spProxy.getMaxHintWindow()}} to add a new nodetool
command (such as {{nodetool handoffwindow}} or similar) instead. 

> Provide max hint window as part of nodetool
> -------------------------------------------
>
>                 Key: CASSANDRA-13728
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Milan Milosevic
>            Assignee: Varun Gupta
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.0.15, 3.11.1
>
>         Attachments: display-max-hint-handoff-period.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The information is
available through StorageProxyMBean, though. Since max hint window information is needed in
order to asses what kind of failure recovery should be performed for a node that goes down
(bootstrap or just restart), it would be handy if max hint window is easily accessible using
nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 10800000
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean from the StatusHandoff
class). I can provide the patch for this, if it is agreed that this it right approach.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message