cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-12373) 3.0 breaks CQL compatibility with super columns families
Date Wed, 30 Aug 2017 12:09:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146940#comment-16146940
] 

Alex Petrov edited comment on CASSANDRA-12373 at 8/30/17 12:08 PM:
-------------------------------------------------------------------

[~slebresne] thank you for the review.

I have fixed the problems with dense/non-dense supercolumns. It looks like from the CQL perspective
non-dense SC tables are treated as if they were "normal" tables, since the internal map column
isn't revealed through the CQL operations in any way. Of course, from the thrift perspective
this is quite different. While going through the patch I've noticed several more problems,
namely: 

  * counters were not fully supported (they did work for the reads, however writes were not
functional)
  * LWTs were not working
  * {{SELECT}} queries with the supercolumn key restriction was working incorrectly 

There were several more smaller fixes. All these things are now covered with tests. I've also
updated the patch with your suggestions. Pushed the changes to the [3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...ifesdjeen:12373-3.0]
branch to possibly save some cycles. 3.11 rebase should be relatively easy, with some minor
changes. [2.2|https://github.com/apache/cassandra/compare/cassandra-2.2...ifesdjeen:12373-2.2]
version of branch contains updated tests to make the comparison with an older version simpler.



was (Author: ifesdjeen):
[~slebresne] thank you for the review.

I have fixed the problems with dense/non-dense supercolumns. It looks like from the CQL perspective
non-dense SC tables are treated as if they were "normal" tables, since the internal map column
isn't revealed through the CQL operations in any way. Of course, from the thrift perspective
this is quite different. While going through the patch I've noticed several more problems,
namely: 

  * counters were not fully supported (they did work for the reads, however writes were not
functional)
  * LWTs were not working
  * {{SELECT}} queries with the supercolumn key restriction was working incorrectly 

There were several more smaller fixes. All these things are now covered with tests. I've also
updated the patch with your suggestions. Pushed the changes to the [3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...ifesdjeen:12373-3.0]
branch to possibly save some cycles. 3.11 rebase should be relatively easy, with some minor
changes. 

> 3.0 breaks CQL compatibility with super columns families
> --------------------------------------------------------
>
>                 Key: CASSANDRA-12373
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12373
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL
>            Reporter: Sylvain Lebresne
>            Assignee: Alex Petrov
>             Fix For: 3.0.x, 3.11.x
>
>
> This is a follow-up to CASSANDRA-12335 to fix the CQL side of super column compatibility.
> The details and a proposed solution can be found in the comments of CASSANDRA-12335 but
the crux of the issue is that super column famillies show up differently in CQL in 3.0.x/3.x
compared to 2.x, hence breaking backward compatibilty.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message