cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-10786) Include hash of result set metadata in prepared statement id
Date Mon, 07 Aug 2017 20:19:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117190#comment-16117190
] 

Alex Petrov edited comment on CASSANDRA-10786 at 8/7/17 8:18 PM:
-----------------------------------------------------------------

Thank you a lot for the review! 

I completely agree on the fact we should not have {{SNAPSHOT}} in tree, but it's kind of chicken-and-egg
problem since the driver relies on Cassandra for tests and vice versa. I'll talk to the {{java-driver}}
maintainers to make sure we find a proper solution, the last time we talked we agreed that
it makes sense to have more or less final version of the Cassandra patch first 
cc [~adutra] [~omichallat] (could you comment, what'd be the best way to proceed? the current
patch is based off 3.4 driver iirc).

We might also want to wait until {{python}} driver implements this feature since otherwise
{{dtests}} that rely on {{v5}} can't pass 
cc [~andrew.tolbert] (could you comment as well, is it somewhere on the radar for you? Might
make sense to make sure python driver has it before we can merge)




was (Author: ifesdjeen):
I completely agree on the fact we should not have {{SNAPSHOT}} in tree, but it's kind of chicken-and-egg
problem since the driver relies on Cassandra for tests and vice versa. I'll talk to the {{java-driver}}
maintainers to make sure we find a proper solution, the last time we talked we agreed that
it makes sense to have more or less final version of the Cassandra patch first 
cc [~adutra] [~omichallat] (could you comment, what'd be the best way to proceed? the current
patch is based off 3.4 driver iirc).

We might also want to wait until {{python}} driver implements this feature since otherwise
{{dtests}} that rely on {{v5}} can't pass 
cc [~andrew.tolbert] (could you comment as well, is it somewhere on the radar for you? Might
make sense to make sure python driver has it before we can merge)



> Include hash of result set metadata in prepared statement id
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-10786
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10786
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: CQL
>            Reporter: Olivier Michallat
>            Assignee: Alex Petrov
>            Priority: Minor
>              Labels: client-impacting, doc-impacting, protocolv5
>             Fix For: 4.x
>
>
> *_Initial description:_*
> This is a follow-up to CASSANDRA-7910, which was about invalidating a prepared statement
when the table is altered, to force clients to update their local copy of the metadata.
> There's still an issue if multiple clients are connected to the same host. The first
client to execute the query after the cache was invalidated will receive an UNPREPARED response,
re-prepare, and update its local metadata. But other clients might miss it entirely (the MD5
hasn't changed), and they will keep using their old metadata. For example:
> # {{SELECT * ...}} statement is prepared in Cassandra with md5 abc123, clientA and clientB
both have a cache of the metadata (columns b and c) locally
> # column a gets added to the table, C* invalidates its cache entry
> # clientA sends an EXECUTE request for md5 abc123, gets UNPREPARED response, re-prepares
on the fly and updates its local metadata to (a, b, c)
> # prepared statement is now in C*’s cache again, with the same md5 abc123
> # clientB sends an EXECUTE request for id abc123. Because the cache has been populated
again, the query succeeds. But clientB still has not updated its metadata, it’s still (b,c)
> One solution that was suggested is to include a hash of the result set metadata in the
md5. This way the md5 would change at step 3, and any client using the old md5 would get an
UNPREPARED, regardless of whether another client already reprepared.
> -----
> *_Resolution (2017/02/13):_*
> The following changes were made to native protocol v5:
> - the PREPARED response includes {{result_metadata_id}}, a hash of the result set metadata.
> - every EXECUTE message must provide {{result_metadata_id}} in addition to the prepared
statement id. If it doesn't match the current one on the server, it means the client is operating
on a stale schema.
> - to notify the client, the server returns a ROWS response with a new {{Metadata_changed}}
flag, the new {{result_metadata_id}} and the updated result metadata (this overrides the {{No_metadata}}
flag, even if the client had requested it)
> - the client updates its copy of the result metadata before it decodes the results.
> So the scenario above would now look like:
> # {{SELECT * ...}} statement is prepared in Cassandra with md5 abc123, and result set
(b, c) that hashes to cde456
> # column a gets added to the table, C* does not invalidate its cache entry, but only
updates the result set to (a, b, c) which hashes to fff789
> # client sends an EXECUTE request for (statementId=abc123, resultId=cde456) and skip_metadata
flag
> # cde456!=fff789, so C* responds with ROWS(..., no_metadata=false, metadata_changed=true,
new_metadata_id=fff789,col specs for (a,b,c))
> # client updates its column specifications, and will send the next execute queries with
(statementId=abc123, resultId=fff789)
> This works the same with multiple clients.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message