Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7ACCD200CD3 for ; Fri, 28 Jul 2017 14:15:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 791BB16CB20; Fri, 28 Jul 2017 12:15:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BDD4416CB1D for ; Fri, 28 Jul 2017 14:15:04 +0200 (CEST) Received: (qmail 55278 invoked by uid 500); 28 Jul 2017 12:15:03 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 55267 invoked by uid 99); 28 Jul 2017 12:15:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jul 2017 12:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 69CFFC3353 for ; Fri, 28 Jul 2017 12:15:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kcYvI6YgV2nT for ; Fri, 28 Jul 2017 12:15:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E3FBB5FBB1 for ; Fri, 28 Jul 2017 12:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C999CE0AF9 for ; Fri, 28 Jul 2017 12:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1B97924D25 for ; Fri, 28 Jul 2017 12:15:00 +0000 (UTC) Date: Fri, 28 Jul 2017 12:15:00 +0000 (UTC) From: "Robert Stupp (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-13371) Remove legacy auth tables support MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 28 Jul 2017 12:15:05 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104870#comment-16104870 ] Robert Stupp commented on CASSANDRA-13371: ------------------------------------------ +1 Just two nits, feel free to do those on commit: * {{CassandraRoleManager.getRoleFromTable}} is only used from {{getRole}} - code can be moved into {{getRole}} * {{import org.apache.cassandra.schema.Schema;}} is no longer needed in PasswordAuthenticator > Remove legacy auth tables support > --------------------------------- > > Key: CASSANDRA-13371 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13371 > Project: Cassandra > Issue Type: Improvement > Components: Auth > Reporter: Stefan Podkowinski > Assignee: Stefan Podkowinski > Labels: security > Fix For: 4.x > > > Starting with Cassandra 3.0, we include support for converting pre CASSANDRA-7653 user tables, until they will be dropped by the operator. Converting e.g. permissions happens by simply copying all of them from {{permissions}} -> {{role_permissions}}, until the {{permissions}} table has been dropped. > Upgrading to 4.0 will only be possible from 3.0 upwards, so I think it's safe to assume that the new permissions table has already been populated, whether the old table was dropped or not. Therefor I'd suggest to just get rid of the legacy support. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org