Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 66E70200CCF for ; Mon, 24 Jul 2017 10:11:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6522C1649C8; Mon, 24 Jul 2017 08:11:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C215F1649A9 for ; Mon, 24 Jul 2017 10:11:10 +0200 (CEST) Received: (qmail 88387 invoked by uid 500); 24 Jul 2017 08:11:09 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 88368 invoked by uid 99); 24 Jul 2017 08:11:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jul 2017 08:11:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3E04CC0E0E for ; Mon, 24 Jul 2017 08:11:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.2 X-Spam-Level: X-Spam-Status: No, score=-99.2 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Rff913IKP01U for ; Mon, 24 Jul 2017 08:11:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 46BCD60E9E for ; Mon, 24 Jul 2017 08:11:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BDF4EE02FD for ; Mon, 24 Jul 2017 08:11:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AAB6021EE9 for ; Mon, 24 Jul 2017 08:11:00 +0000 (UTC) Date: Mon, 24 Jul 2017 08:11:00 +0000 (UTC) From: "Sundar Srinivasan (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-12922) Bloom filter miss counts are not measured correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 24 Jul 2017 08:11:11 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sundar Srinivasan updated CASSANDRA-12922: ------------------------------------------ Attachment: 12922-trunk.txt Please let me know if this looks fine and I will proceed to write a unit test as noted for the previous fix. > Bloom filter miss counts are not measured correctly > --------------------------------------------------- > > Key: CASSANDRA-12922 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12922 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths > Reporter: Branimir Lambov > Assignee: Mahdi Mohammadi > Labels: lhf > Fix For: 4.x > > Attachments: 12922-trunk.txt > > > Bloom filter hits and misses are evaluated incorrectly in {{BigTableReader.getPosition}}: we properly record hits, but not misses. In particular, if we don't find a match for a key in the index, which is where almost all non-matches will be rejected, [we don't record a bloom filter false positive|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/big/BigTableReader.java#L228]. > This leads to very misleading output from e.g. {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org