Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3607D200CCA for ; Wed, 19 Jul 2017 11:17:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 34620168964; Wed, 19 Jul 2017 09:17:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 819A616895C for ; Wed, 19 Jul 2017 11:17:06 +0200 (CEST) Received: (qmail 90849 invoked by uid 500); 19 Jul 2017 09:17:03 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 90838 invoked by uid 99); 19 Jul 2017 09:17:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jul 2017 09:17:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 59508C2A23 for ; Wed, 19 Jul 2017 09:17:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Fhh9cKJ6O7sx for ; Wed, 19 Jul 2017 09:17:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BF4D35FCBA for ; Wed, 19 Jul 2017 09:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1D10FE0280 for ; Wed, 19 Jul 2017 09:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D089F21EA3 for ; Wed, 19 Jul 2017 09:17:00 +0000 (UTC) Date: Wed, 19 Jul 2017 09:17:00 +0000 (UTC) From: "Anthony Grasso (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9988) Introduce leaf-only iterator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 19 Jul 2017 09:17:07 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092832#comment-16092832 ] Anthony Grasso commented on CASSANDRA-9988: ------------------------------------------- Have reviewed the code. Ran the Microbench tests {noformat} ant test -Dtest.name=org.apache.cassandra.test.microbench.CompactionBench ant test -Dtest.name=org.apache.cassandra.test.microbench.BTreeSearchIteratorBench ant test -Dtest.name=org.apache.cassandra.test.microbench.DirectorySizerBench ant test -Dtest.name=org.apache.cassandra.test.microbench.FastThreadExecutor ant test -Dtest.name=org.apache.cassandra.test.microbench.FastThreadLocalBench ant test -Dtest.name=org.apache.cassandra.test.microbench.MutationBench ant test -Dtest.name=org.apache.cassandra.test.microbench.OutputStreamBench ant test -Dtest.name=org.apache.cassandra.test.microbench.OutputStreamBench ant test -Dtest.name=org.apache.cassandra.test.microbench.OutputStreamBench ant test -Dtest.name=org.apache.cassandra.test.microbench.PendingRangesBench ant test -Dtest.name=org.apache.cassandra.test.microbench.ReadWriteTest ant test -Dtest.name=org.apache.cassandra.test.microbench.StreamingHistogramBench ant test -Dtest.name=org.apache.cassandra.test.microbench.PartitionImplementationTest {noformat} Ran the partition unit tests {noformat} ant test -Dtest.name=org.apache.cassandra.db.partition.PartitionImplementationTest ant test -Dtest.name=org.apache.cassandra.db.partition.PartitionUpdateTest {noformat} Changes look good to me. > Introduce leaf-only iterator > ---------------------------- > > Key: CASSANDRA-9988 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9988 > Project: Cassandra > Issue Type: Sub-task > Reporter: Benedict > Assignee: Jay Zhuang > Priority: Minor > Labels: patch > Fix For: 4.0 > > Attachments: 9988-trunk-new.txt, 9988-trunk-new-update.txt, trunk-9988.txt > > > In many cases we have small btrees, small enough to fit in a single leaf page. In this case it _may_ be more efficient to specialise our iterator. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org