Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 634BF200CC8 for ; Fri, 14 Jul 2017 12:55:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 61BB416D8B5; Fri, 14 Jul 2017 10:55:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AB04C16D8B4 for ; Fri, 14 Jul 2017 12:55:08 +0200 (CEST) Received: (qmail 62151 invoked by uid 500); 14 Jul 2017 10:55:07 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 62126 invoked by uid 99); 14 Jul 2017 10:55:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jul 2017 10:55:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 21357C0B9D for ; Fri, 14 Jul 2017 10:55:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iPhevV2twxsr for ; Fri, 14 Jul 2017 10:55:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A7AD660CD3 for ; Fri, 14 Jul 2017 10:55:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 62C94E08C6 for ; Fri, 14 Jul 2017 10:55:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5FF2324746 for ; Fri, 14 Jul 2017 10:55:02 +0000 (UTC) Date: Fri, 14 Jul 2017 10:55:02 +0000 (UTC) From: "Vladimir Yudovin (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-8596) Display datacenter/rack info for offline nodes - PropertyFileSnitch MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 14 Jul 2017 10:55:09 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Yudovin updated CASSANDRA-8596: ---------------------------------------- Flags: Patch Attachment: file_snitch.patch ---------AbstractEndpointSnitch might be a better choice This class has no getDC/Rack methods. AbstractNetworkTopologySnitch has, but different snitches have their own implementations, like EC2Snitch. I uploaded new patch *file_snitch.patch*, with simpler implementation, like EC2Snitch. > Display datacenter/rack info for offline nodes - PropertyFileSnitch > ------------------------------------------------------------------- > > Key: CASSANDRA-8596 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8596 > Project: Cassandra > Issue Type: Improvement > Reporter: Vladimir Yudovin > Priority: Minor > Attachments: ByteBufferUtils.diff, file_snitch.patch > > > When using GossipPropertyFileSnitch "nodetool status" shows default (from cassandra-topology.properties ) datacenter/rack for offline nodes. > It happens because offline nodes are not in endpointMap, and thus getRawEndpointInfo returns default DC/rack is returned (PropertyFileSnitch.java). > I suggest to take info for those nodes from system.peers tables - just like > SELECT data_center,rack FROM system.peers WHERE peer='10.0.0.1' > Patch attached. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org