cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-13714) response to EchoMessage is sent on wrong connection
Date Thu, 20 Jul 2017 21:26:00 GMT
Jason Brown created CASSANDRA-13714:
---------------------------------------

             Summary: response to EchoMessage is sent on wrong connection
                 Key: CASSANDRA-13714
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13714
             Project: Cassandra
          Issue Type: Bug
          Components: Distributed Metadata
            Reporter: Jason Brown
            Priority: Trivial


Followup to CASSANDRA-13713. To force the {{EchoResponse}} response onto the correct stage,
we should create a new message type, {{EchoResponseMessage}}, and map it appropriately in
{{MessagingService.verbStages}}. Mapping the response message correctly will allow the response
to be sent on the gossip connection, and then allow us to process it immediately on the gossip
stage, rather the request_response stage.

One serious problem to consider is the upgrade scenario, where the non-upgraded node expects
a simple RequestResponse message that maps to a callback. If the upgraded node tries to send
the new {{EchoResponseMessage}}, it will be ignored by the old node. And thus we get into
some weird state where gossip can't communicate directly, even though the actual TCP connection
and wrapper channel is setup correctly. (I haven't thought about all the oddball fall out
that can occur as a rolling upgrade rolls out).

Thus, due to that complexity, versus the triviality/near-zero impact of the bug (sending the
response on the wrong channel is not a big deal), I feel this ticket is largely not worth
bothering with. That said, I at least want to capture the problem for posterity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message