cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Knighton (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-13713) Move processing of EchoMessage response to gossip stage
Date Wed, 26 Jul 2017 19:42:00 GMT


Joel Knighton commented on CASSANDRA-13713:

The simple change here seems good - do you think it's worth doing something to map the echo
response directly to the gossip stage and gossip connection? This seems like a good fix for
the present state, but I think perhaps a different verb or a way to map individual REQUEST_RESPONSE
verbs to a stage/connection makes sense on a longer term.

> Move processing of EchoMessage response to gossip stage
> -------------------------------------------------------
>                 Key: CASSANDRA-13713
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Distributed Metadata
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>             Fix For: 4.x
> Currently, when a node receives an {{EchoMessage}}, is sends a simple ACK reply back
(see {{EchoVerbHandler}}). The ACK is sent on the small message connection, and because it
is 'generically' typed as {{Verb.REQUEST_RESPONSE}}, is consumed on a {{Stage.REQUEST_RESPONSE}}
thread. The proper thread for this response to be consumed is {{Stage.GOSSIP}}, that way we
can move more of the updating of the gossip state to a single, centralized thread, and less
abuse of gossip's shared mutable state can occur.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message