cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-13526) nodetool cleanup on KS with no replicas should remove old data, not silently complete
Date Wed, 19 Jul 2017 05:00:02 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092573#comment-16092573
] 

Jeff Jirsa edited comment on CASSANDRA-13526 at 7/19/17 4:59 AM:
-----------------------------------------------------------------

Patch looks good to me, dtest looks good as well, with two comments:

1) New dtest repo is https://github.com/apache/cassandra-dtest

2) You should remove dc1 from the replication strategy [here|https://github.com/riptano/cassandra-dtest/commit/15bf712988fb50ae29994da246dec186beff69bd#diff-9d7bd37d410a5598b9700b71476845ebR159]
to be very explicit about what we expect to happen.

Would you backport to 3.0 and 3.11 ? 



was (Author: jjirsa):
Patch looks good to me, dtest looks good as well, with two comments:

1) New dtest repo is https://github.com/apache/cassandra-dtest

2) You should remove dc1 from the replication strategy [here|https://github.com/riptano/cassandra-dtest/commit/15bf712988fb50ae29994da246dec186beff69bd#diff-9d7bd37d410a5598b9700b71476845ebR159]
to be very explicit about what we expect to happen.


> nodetool cleanup on KS with no replicas should remove old data, not silently complete
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13526
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13526
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Jeff Jirsa
>            Assignee: ZhaoYang
>              Labels: usability
>             Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x
>
>
> From the user list:
> https://lists.apache.org/thread.html/5d49cc6bbc6fd2e5f8b12f2308a3e24212a55afbb441af5cb8cd4167@%3Cuser.cassandra.apache.org%3E
> If you have a multi-dc cluster, but some keyspaces not replicated to a given DC, you'll
be unable to run cleanup on those keyspaces in that DC, because [the cleanup code will see
no ranges and exit early|https://github.com/apache/cassandra/blob/4cfaf85/src/java/org/apache/cassandra/db/compaction/CompactionManager.java#L427-L441]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message