cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ZhaoYang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13082) Suspect OnDiskIndex.IteratorOrder.startAt code for ASC
Date Wed, 12 Jul 2017 06:58:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083545#comment-16083545
] 

ZhaoYang commented on CASSANDRA-13082:
--------------------------------------

isn't it 
{quote}
  return inclusive && found.cmp == 0 ? found.index : found.index - 1;
{quote}

> Suspect OnDiskIndex.IteratorOrder.startAt code for ASC
> ------------------------------------------------------
>
>                 Key: CASSANDRA-13082
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13082
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 4.x
>
>
> startAt for ASC does
>                 case ASC:
>                     if (found.cmp < 0) // search term was bigger then whole data set
>                         return found.index;
>                     return inclusive && (found.cmp == 0 || found.cmp < 0)
? found.index : found.index - 1;
> which is equivalent to
>                 case ASC:
>                     if (found.cmp < 0) // search term was bigger then whole data set
>                         return found.index;
>                     return inclusive ? found.index : found.index - 1;
> which seems wrong. Is the parenthesis wrong here?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message