Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5CF2A200CC2 for ; Wed, 21 Jun 2017 01:48:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5C2A3160BEF; Tue, 20 Jun 2017 23:48:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A3144160BE1 for ; Wed, 21 Jun 2017 01:48:03 +0200 (CEST) Received: (qmail 14719 invoked by uid 500); 20 Jun 2017 23:48:02 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 14708 invoked by uid 99); 20 Jun 2017 23:48:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jun 2017 23:48:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6BC5C1B0E0F for ; Tue, 20 Jun 2017 23:48:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id RBAy2Ubv7EJG for ; Tue, 20 Jun 2017 23:48:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 132D75F523 for ; Tue, 20 Jun 2017 23:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5B883E0069 for ; Tue, 20 Jun 2017 23:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1872D240A5 for ; Tue, 20 Jun 2017 23:48:00 +0000 (UTC) Date: Tue, 20 Jun 2017 23:48:00 +0000 (UTC) From: "Jeff Jirsa (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CASSANDRA-13626) Check hashed password matches expected bcrypt hash format before checking MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 20 Jun 2017 23:48:04 -0000 Jeff Jirsa created CASSANDRA-13626: -------------------------------------- Summary: Check hashed password matches expected bcrypt hash format before checking Key: CASSANDRA-13626 URL: https://issues.apache.org/jira/browse/CASSANDRA-13626 Project: Cassandra Issue Type: Bug Components: Auth Reporter: Jeff Jirsa Assignee: Jeff Jirsa Priority: Minor Fix For: 3.0.x, 3.11.x, 4.x We use {{Bcrypt.checkpw}} in the auth subsystem, but do a reasonably poor job of guaranteeing that the hashed password we send to it is really a hashed password, and {{checkpw}} does an even worse job of failing nicely. We should at least sanity check the hash complies with the expected format prior to validating. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org