Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B5443200C7C for ; Mon, 5 Jun 2017 10:38:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B45DB160BBF; Mon, 5 Jun 2017 08:38:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06B14160BD4 for ; Mon, 5 Jun 2017 10:38:08 +0200 (CEST) Received: (qmail 38379 invoked by uid 500); 5 Jun 2017 08:38:08 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 38367 invoked by uid 99); 5 Jun 2017 08:38:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jun 2017 08:38:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C9340C0096 for ; Mon, 5 Jun 2017 08:38:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id WXcvPKF5T905 for ; Mon, 5 Jun 2017 08:38:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D06A25FB96 for ; Mon, 5 Jun 2017 08:38:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2F550E0D4D for ; Mon, 5 Jun 2017 08:38:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CE55521B5A for ; Mon, 5 Jun 2017 08:38:04 +0000 (UTC) Date: Mon, 5 Jun 2017 08:38:04 +0000 (UTC) From: "Marcus Eriksson (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CASSANDRA-13068) Fully expired sstable not dropped when running out of disk space MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 05 Jun 2017 08:38:09 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036678#comment-16036678 ] Marcus Eriksson edited comment on CASSANDRA-13068 at 6/5/17 8:37 AM: --------------------------------------------------------------------- instead of that {{fullyExpiredSSTables.isEmpty()}} check could we just subtract the size of the {{fullyExpiredSSTables}} from {{expectedWriteSize}} in {{CompactionTask#checkAvailableDiskSpace}}? was (Author: krummas): instead of that {{fullyExpiredSSTables.isEmpty()}} could we just subtract the size of the {{fullyExpiredSSTables}} from {{expectedWriteSize}} in {{CompactionTask#checkAvailableDiskSpace}}? > Fully expired sstable not dropped when running out of disk space > ---------------------------------------------------------------- > > Key: CASSANDRA-13068 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13068 > Project: Cassandra > Issue Type: Bug > Components: Compaction > Reporter: Marcus Eriksson > Assignee: Lerh Chuan Low > Labels: lhf > Fix For: 3.0.x, 3.11.x, 4.x > > > If a fully expired sstable is larger than the remaining disk space we won't run the compaction that can drop the sstable (ie, in our disk space check should not include the fully expired sstables) -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org