Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 2 Jun 2017 08:19:04 +0000 (UTC)
From: "Alex Petrov (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13025830.1480991031000.349630.1496391544595@Atlassian.JIRA>
In-Reply-To: <JIRA.13025830.1480991031000@Atlassian.JIRA>
References: <JIRA.13025830.1480991031000@Atlassian.JIRA> <JIRA.13025830.1480991031344@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (CASSANDRA-13004) Corruption while adding a
 column to a table
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 02 Jun 2017 08:19:11 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-13004?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D16033682#comment-16033682 ]=20

Alex Petrov edited comment on CASSANDRA-13004 at 6/2/17 8:18 AM:
-----------------------------------------------------------------

bq. In ReadResponse , we have two asserts that require assert version =3D=
=3D MessagingService.VERSION_30 - shouldn't those need to be adjusted (here=
 and here ) ; frankly I'm shocked that we didn't fail more dtests without t=
hose changes?

I'm sorry, my initial patch had a copy/paste typo {{VERSION_31 =3D 30}}. I =
have corrected and force-pushed it, although that was already after running=
 tests. I didn't think the change was significant enough.=20

When fixing, I've copied the message from [trunk|https://github.com/apache/=
cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/src/java/org/apache=
/cassandra/db/ReadResponse.java#L221-L224] for consistency.=20

I've addressed the brackets and version issues as well. CI is now triggered=
, too. Links are the same.


was (Author: ifesdjeen):
bq. In ReadResponse , we have two asserts that require assert version =3D=
=3D MessagingService.VERSION_30 - shouldn't those need to be adjusted (here=
 and here ) ; frankly I'm shocked that we didn't fail more dtests without t=
hose changes?

I'm sorry, my initial patch had a copy/paste typo {{VERSION_31 =3D 30}}. I =
have corrected and force-pushed it, although that was already after running=
 tests. I didn't think the change was significant enough.=20

When fixing, I've copied the message from [trunk|https://github.com/apache/=
cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/src/java/org/apache=
/cassandra/db/ReadResponse.java#L221-L224] for consistency.=20

I've addressed the brackets and version issues as well. CI is now triggered=
, too.

> Corruption while adding a column to a table
> -------------------------------------------
>
>                 Key: CASSANDRA-13004
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1300=
4
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Distributed Metadata
>            Reporter: Stanislav Vishnevskiy
>            Assignee: Alex Petrov
>            Priority: Blocker
>             Fix For: 3.0.x, 3.11.x, 4.x
>
>
> We had the following schema in production.=20
> {code:none}
> CREATE TYPE IF NOT EXISTS discord_channels.channel_recipient (
>     nick text
> );
> CREATE TYPE IF NOT EXISTS discord_channels.channel_permission_overwrite (
>     id bigint,
>     type int,
>     allow_ int,
>     deny int
> );
> CREATE TABLE IF NOT EXISTS discord_channels.channels (
>     id bigint,
>     guild_id bigint,
>     type tinyint,
>     name text,
>     topic text,
>     position int,
>     owner_id bigint,
>     icon_hash text,
>     recipients map<bigint, frozen<channel_recipient>>,
>     permission_overwrites map<bigint, frozen<channel_permission_overwrite=
>>,
>     bitrate int,
>     user_limit int,
>     last_pin_timestamp timestamp,
>     last_message_id bigint,
>     PRIMARY KEY (id)
> );
> {code}
> And then we executed the following alter.
> {code:none}
> ALTER TABLE discord_channels.channels ADD application_id bigint;
> {code}
> And one row (that we can tell) got corrupted at the same time and could n=
o longer be read from the Python driver.=20
> {code:none}
> [E 161206 01:56:58 geventreactor:141] Error decoding response from Cassan=
dra. ver(4); flags(0000); stream(27); op(8); offset(9); len(887); buffer: '=
\x84\x00\x00\x1b\x08\x00\x00\x03w\x00\x00\x00\x02\x00\x00\x00\x01\x00\x00\x=
00\x0f\x00\x10discord_channels\x00\x08channels\x00\x02id\x00\x02\x00\x0eapp=
lication_id\x00\x02\x00\x07bitrate\x00\t\x00\x08guild_id\x00\x02\x00\ticon_=
hash\x00\r\x00\x0flast_message_id\x00\x02\x00\x12last_pin_timestamp\x00\x0b=
\x00\x04name\x00\r\x00\x08owner_id\x00\x02\x00\x15permission_overwrites\x00=
!\x00\x02\x000\x00\x10discord_channels\x00\x1cchannel_permission_overwrite\=
x00\x04\x00\x02id\x00\x02\x00\x04type\x00\t\x00\x06allow_\x00\t\x00\x04deny=
\x00\t\x00\x08position\x00\t\x00\nrecipients\x00!\x00\x02\x000\x00\x10disco=
rd_channels\x00\x11channel_recipient\x00\x01\x00\x04nick\x00\r\x00\x05topic=
\x00\r\x00\x04type\x00\x14\x00\nuser_limit\x00\t\x00\x00\x00\x01\x00\x00\x0=
0\x08\x03\x8a\x19\x8e\xf8\x82\x00\x01\xff\xff\xff\xff\x00\x00\x00\x04\x00\x=
00\xfa\x00\x00\x00\x00\x08\x00\x00\xfa\x00\x00\xf8G\xc5\x00\x00\x00\x00\x00=
\x00\x00\x08\x03\x8b\xc0\xb5nB\x00\x02\x00\x00\x00\x08G\xc5\xffI\x98\xc4\xb=
4(\x00\x00\x00\x03\x8b\xc0\xa8\xff\xff\xff\xff\x00\x00\x01<\x00\x00\x00\x06=
\x00\x00\x00\x08\x03\x81L\xea\xfc\x82\x00\n\x00\x00\x00$\x00\x00\x00\x08\x0=
3\x81L\xea\xfc\x82\x00\n\x00\x00\x00\x04\x00\x00\x00\x01\x00\x00\x00\x04\x0=
0\x00\x08\x00\x00\x00\x00\x04\x00\x00\x00\x00\x00\x00\x00\x08\x03\x8a\x1e\x=
e6\x8b\x80\x00\n\x00\x00\x00$\x00\x00\x00\x08\x03\x8a\x1e\xe6\x8b\x80\x00\n=
\x00\x00\x00\x04\x00\x00\x00\x00\x00\x00\x00\x040\x07\xf8Q\x00\x00\x00\x04\=
x00\x00\x00\x00\x00\x00\x00\x08\x03\x8a\x1f\x1b{\x82\x00\x00\x00\x00\x00$\x=
00\x00\x00\x08\x03\x8a\x1f\x1b{\x82\x00\x00\x00\x00\x00\x04\x00\x00\x00\x00=
\x00\x00\x00\x04\x00\x07\xf8Q\x00\x00\x00\x04\x10\x00\x00\x00\x00\x00\x00\x=
08\x03\x8a\x1fH6\x82\x00\x01\x00\x00\x00$\x00\x00\x00\x08\x03\x8a\x1fH6\x82=
\x00\x01\x00\x00\x00\x04\x00\x00\x00\x00\x00\x00\x00\x04\x00\x05\xe8A\x00\x=
00\x00\x04\x10\x02\x00\x00\x00\x00\x00\x08\x03\x8a+=3D\xca\xc0\x00\n\x00\x0=
0\x00$\x00\x00\x00\x08\x03\x8a+=3D\xca\xc0\x00\n\x00\x00\x00\x04\x00\x00\x0=
0\x00\x00\x00\x00\x04\x00\x00\x08\x00\x00\x00\x00\x04\x00\x00\x00\x00\x00\x=
00\x00\x08\x03\x8a\x8f\x979\x80\x00\n\x00\x00\x00$\x00\x00\x00\x08\x03\x8a\=
x8f\x979\x80\x00\n\x00\x00\x00\x04\x00\x00\x00\x00\x00\x00\x00\x04\x00\x00\=
x00\x00\x00\x00\x00\x04\x00 \x08\x01\x00\x00\x00\x04\xc4\xb4(\x00\xff\xff\x=
ff\xff\x00\x00\x00O[f\x80Q\x07general\x05\xf8G\xc5\xffI\x98\xc4\xb4(\x00\xf=
8O[f\x80Q\x00\x00\x00\x02\x04\xf8O[f\x80Q\x00\xf8G\xc5\xffI\x98\x01\x00\x00=
\xf8O[f\x80Q\x00\x00\x00\x00\xf8G\xc5\xffI\x97\xc4\xb4(\x06\x00\xf8O\x7fe\x=
1fm\x08\x03\x00\x00\x00\x01\x00\x00\x00\x00\x04\x00\x00\x00\x00'
> {code}
> And then in cqlsh when trying to read the row we got this.=20
> {code:none}
> /usr/bin/cqlsh.py:632: DateOverFlowWarning: Some timestamps are larger th=
an Python datetime can represent. Timestamps are displayed in milliseconds =
from epoch.
> Traceback (most recent call last):
>   File "/usr/bin/cqlsh.py", line 1301, in perform_simple_statement
>     result =3D future.result()
>   File "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.5.0.pos=
t0-d8d0456.zip/cassandra-driver-3.5.0.post0-d8d0456/cassandra/cluster.py", =
line 3650, in result
>     raise self._final_exception
> UnicodeDecodeError: 'utf8' codec can't decode byte 0x80 in position 2: in=
valid start byte
> {code}
> We tried to read the data and it would refuse to read the name column (th=
e UTF8 error) and the last_pin_timestamp column had an absurdly large value=
.
> We ended up rewriting the whole row as we had the data in another place a=
nd it fixed the problem. However there is clearly a race condition in the s=
chema change sub-system.
> Any ideas?


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org