Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 065BB200CBE for ; Thu, 22 Jun 2017 13:18:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 05218160BE5; Thu, 22 Jun 2017 11:18:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 48091160BE7 for ; Thu, 22 Jun 2017 13:18:05 +0200 (CEST) Received: (qmail 37305 invoked by uid 500); 22 Jun 2017 11:18:03 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 37294 invoked by uid 99); 22 Jun 2017 11:18:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jun 2017 11:18:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9435EC32C0 for ; Thu, 22 Jun 2017 11:18:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.21 X-Spam-Level: X-Spam-Status: No, score=-99.21 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GgqI-xbFZ8xN for ; Thu, 22 Jun 2017 11:18:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CB10961107 for ; Thu, 22 Jun 2017 11:18:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 08DD1E06C4 for ; Thu, 22 Jun 2017 11:18:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3A222240A5 for ; Thu, 22 Jun 2017 11:18:00 +0000 (UTC) Date: Thu, 22 Jun 2017 11:18:00 +0000 (UTC) From: =?utf-8?Q?Andr=C3=A9s_de_la_Pe=C3=B1a_=28JIRA=29?= To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10130) Node failure during 2i update after streaming can have incomplete 2i when restarted MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 22 Jun 2017 11:18:06 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-10130?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16059186#comment-16059186 ]=20 Andr=C3=A9s de la Pe=C3=B1a commented on CASSANDRA-10130: ----------------------------------------------- bq. 1) Shouldn't we set the [throwable|https://github.com/adelapena/cassand= ra/compare/ca7da30f621e742f85b6a7b1f66d320ba224a6a4...adelapena:0f6972eacda= b6b0c81e00d8c0c59968106d3f462#diff-0ccfd193eadf8f1c2a48cf846b4eb791R549] nu= ll on TestingIndex#clear()? Yes, I totally forgot to reset the two throwables, fixed [here|https://gith= ub.com/adelapena/cassandra/commit/387b21f2e8d2c1f6cc6b5f46be8ed0039d32c0bf]= . bq. 2) Shouldn't we test the stability inspector on index creation too? There were tests for the the stability inspector on index creation [here|ht= tps://github.com/adelapena/cassandra/blob/387b21f2e8d2c1f6cc6b5f46be8ed0039= d32c0bf/test/unit/org/apache/cassandra/index/SecondaryIndexManagerTest.java= #L477-L512].=20 > Node failure during 2i update after streaming can have incomplete 2i when= restarted > -------------------------------------------------------------------------= ---------- > > Key: CASSANDRA-10130 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1013= 0 > Project: Cassandra > Issue Type: Bug > Components: Coordination > Reporter: Yuki Morishita > Assignee: Andr=C3=A9s de la Pe=C3=B1a > Priority: Minor > > Since MV/2i update happens after SSTables are received, node failure duri= ng MV/2i update can leave received SSTables live when restarted while MV/2i= are partially up to date. > We can add some kind of tracking mechanism to automatically rebuild at th= e startup, or at least warn user when the node restarts. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org For additional commands, e-mail: commits-help@cassandra.apache.org