Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 2 Jun 2017 16:11:04 +0000 (UTC)
From: "Sergio Bossa (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12857283.1440006050000.353264.1496419864278@Atlassian.JIRA>
In-Reply-To: <JIRA.12857283.1440006050000@Atlassian.JIRA>
References: <JIRA.12857283.1440006050000@Atlassian.JIRA> <JIRA.12857283.1440006050745@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CASSANDRA-10130) Node failure during 2i update
 after streaming can have incomplete 2i when restarted
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 02 Jun 2017 16:11:09 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-10130?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D16034963#comment-16034963 ]=20

Sergio Bossa commented on CASSANDRA-10130:
------------------------------------------

bq. It's still possible that an index is created after the SSTableAddedNoti=
fication but before all sstables are added to the tracker

That made me also think of an ABA-like race, where a new index is registere=
d _and built_ in-between the two notifications, causing it to miss the new-=
to-be-added sstables. Weird stuff, and overall excellent points [~paulorica=
rdomg].

Given most of the races come from the 2-phase event-based solution, I'd say=
 to simplify it in a way that still at least solves the original issue: tha=
t is, keep just the {{SSTableAddedNotification}}, and mark the index buildi=
ng/built around that; this will not protect against failures happening _whi=
le_ adding SSTables, but again, it would at least solve the original proble=
m of the index itself failing after adding the SSTables and missing to rebu=
ild. Then, we can think about a more complete solution (i.e. one that doesn=
't rebuild the whole index because of a single failed stream) in another ti=
cket.

Thoughts?

> Node failure during 2i update after streaming can have incomplete 2i when=
 restarted
> -------------------------------------------------------------------------=
----------
>
>                 Key: CASSANDRA-10130
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1013=
0
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination
>            Reporter: Yuki Morishita
>            Assignee: Andr=C3=A9s de la Pe=C3=B1a
>            Priority: Minor
>
> Since MV/2i update happens after SSTables are received, node failure duri=
ng MV/2i update can leave received SSTables live when restarted while MV/2i=
 are partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at th=
e startup, or at least warn user when the node restarts.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org