cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul S Hahn (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-13597) interface/cassandra.thrift defines VERSION which conflicts with config.h VERSION #define from thrift
Date Wed, 14 Jun 2017 02:47:00 GMT
Paul S Hahn created CASSANDRA-13597:
---------------------------------------

             Summary: interface/cassandra.thrift defines VERSION which conflicts with config.h
VERSION #define from thrift
                 Key: CASSANDRA-13597
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13597
             Project: Cassandra
          Issue Type: Bug
         Environment: CentOS Linux release 7.3.1611 (Core) 
g++ --version
g++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-3)
thrift version: head built from checkout: 
https://github.com/apache/thrift/commit/b8ee72de5bf9318d50846852082325d0f932682b
            Reporter: Paul S Hahn
            Priority: Trivial
             Fix For: 3.10


std::string VERSION conflicts with pound define VERSION in thrift:

To reproduce:
thrift -gen cpp /var/opt/cassandra/interface/cassandra.thrift

Produces gen-cpp directory:
g++ -Igen-cpp/include -I/usr/include -I/usr/include/thrift -c gen-cpp/cassandra_constants.cpp

In file included from /usr/include/thrift/thrift-config.h:23:0,
                 from /usr/include/thrift/Thrift.h:25,
                 from gen-cpp/include/cassandra_types.h:12,
                 from gen-cpp/include/cassandra_constants.h:10,
                 from gen-cpp/cassandra_constants.cpp:7:
gen-cpp/include/cassandra_constants.h:18:15: error: expected unqualified-id before string
constant

Investigating: 

g++ -Igen-cpp/include -I/usr/include -I/usr/include/thrift -E -dM gen-cpp/cassandra_constants.cpp
 | grep VERSION
...
#define VERSION "1.0.0-dev"

Found file that defines this:
include/thrift/config.h:
#define VERSION "1.0.0-dev"

See also:
http://grokbase.com/t/thrift/user/108vnzs3ct/cpp-generators-code-will-not-compile-under-autoconf

Related to tickets:
CASSANDRA-412
THRIFT-6



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message