cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13570) allow sub-range repairs (specifying -et -st) for a preview of repaired data
Date Fri, 09 Jun 2017 16:55:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044677#comment-16044677
] 

ASF GitHub Bot commented on CASSANDRA-13570:
--------------------------------------------

GitHub user Jollyplum opened a pull request:

    https://github.com/apache/cassandra/pull/119

    allow sub-range repairs (specifying -et -st) for a preview of repaire…

    …d data
    
    Patch by Matt Byrd; Reviewed by _ for CASSANDRA-13570

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jollyplum/cassandra 13570

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cassandra/pull/119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #119
    
----
commit f509d85115ea8693ace36055d7058c2c1a6471d0
Author: Matt Byrd <matthew.l.byrd@gmail.com>
Date:   2017-06-08T23:21:19Z

    allow sub-range repairs (specifying -et -st) for a preview of repaired data
    Patch by Matt Byrd; Reviewed by _ for CASSANDRA-13570

----


> allow sub-range repairs (specifying -et -st) for a preview of repaired data
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13570
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13570
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Matt Byrd
>            Assignee: Matt Byrd
>            Priority: Minor
>             Fix For: 4.x
>
>
> I don't see any inherent reason for restricting preview repairs of repaired data to not
allow specifying start and end tokens. 
> The restriction seems to be coming from the fact that incremental=true in RepairOption,
which is the case but it's not truly an incremental repair since we're only previewing.
> {code:java}
>         if (option.isIncremental() && !option.isGlobal())
>         {
>             throw new IllegalArgumentException("Incremental repairs cannot be run against
a subset of tokens or ranges");
>         }
> {code}
> It would be helpful to allow this, so that operators could sequence a sweep over the
entirety of the token-space in a more gradual fashion.
> Also it might help in examining which portions of the token-space differ.
> Can anyone see any reasons for not allowing this?
> I.e just changing the above to something like:
> {code:java}
>  if (option.isIncremental() && !option.getPreviewKind().isPreview() &&
!option.isGlobal())
>           {
>               throw new IllegalArgumentException("Incremental repairs cannot be run against
a subset of tokens or ranges");
>           }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message