cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10130) Node failure during 2i update after streaming can have incomplete 2i when restarted
Date Thu, 15 Jun 2017 23:45:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051208#comment-16051208
] 

Paulo Motta commented on CASSANDRA-10130:
-----------------------------------------

The current version looks good to me, except for the following minor stylistic nits that I
found that could be improved during review (feel free to take it or disregard):
* [Update queryableIndexes only on markIndexBuilt and markIndexRemoved|https://github.com/pauloricardomg/cassandra/commit/74f3eea2d7aa89b644f1ddbc96f9f6d987a27f73]
* [Rename failedIndexes list to needsFullRebuild|https://github.com/pauloricardomg/cassandra/commit/07be39d7db7030bb5616344074c1c96d27c90d15]
(this is mostly because failed index gives the impression the index is not queryable, while
in reality the index can be queryable but only needs full rebuild)
* [Remove unnecessary marking of index in need of full rebuild on index creation|https://github.com/pauloricardomg/cassandra/commit/856ec08d24f615399b0d4a4b063fc96259f60be4]
* [Warn user to run full rebuild after index failure and log failure stack trace if present|https://github.com/pauloricardomg/cassandra/commit/19b6f3c68d1b00895de2d3da5aec54102b44ce9f]

Great job guys! :)

> Node failure during 2i update after streaming can have incomplete 2i when restarted
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10130
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10130
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination
>            Reporter: Yuki Morishita
>            Assignee: Andrés de la Peña
>            Priority: Minor
>
> Since MV/2i update happens after SSTables are received, node failure during MV/2i update
can leave received SSTables live when restarted while MV/2i are partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at the startup, or
at least warn user when the node restarts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message