cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10130) Node failure during 2i update after streaming can have incomplete 2i when restarted
Date Wed, 14 Jun 2017 20:41:00 GMT


Paulo Motta commented on CASSANDRA-10130:

bq. Let me know if you (and Paulo Motta) have any feedback

I found the lockless version easier to follow and overall I like the simplified approach of
preventing starting a full index rebuild if any other index build is ongoing. Overall I think
this looking very good and nearly good to go, I did some minor updates, please let me know
what do you think:
* [Unify|]
nested try-clause on {{SecondaryIndexManager.buildIndexesBlocking}}
* [Fix|]
doc nits and [remove|]
trailing whitespaces
* The fact that the {{SecondaryIndexManager.rebuildIndexesBlocking}} took a collection of
SSTables as argument and passed {{fullIndexRebuild=true}} downstream was a bit misleading,
since it could be wrongly used for a partial index rebuild with only a subset of the SSTables,
so I [simplified|]
that to expose a single method for full index rebuilds externally which is used by both {{ColumnFamilyStore}}
and tests. I'm not sure if we should keep the {{rebuildFromSSTablesBlocking}} protected or
make it public, I can see if being useful to rebuild a subset of the SSTables but It's not
currently used anywhere, but it could maybe used by extensions.

On a side note, I noticed that [this statement|]
is wrong (missing table name) but it's not throwing exception? Should we create a ticket for

> Node failure during 2i update after streaming can have incomplete 2i when restarted
> -----------------------------------------------------------------------------------
>                 Key: CASSANDRA-10130
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination
>            Reporter: Yuki Morishita
>            Assignee: Andrés de la Peña
>            Priority: Minor
> Since MV/2i update happens after SSTables are received, node failure during MV/2i update
can leave received SSTables live when restarted while MV/2i are partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at the startup, or
at least warn user when the node restarts.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message