cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergio Bossa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-10130) Node failure during 2i update after streaming can have incomplete 2i when restarted
Date Wed, 14 Jun 2017 13:32:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049090#comment-16049090
] 

Sergio Bossa edited comment on CASSANDRA-10130 at 6/14/17 1:31 PM:
-------------------------------------------------------------------

[~adelapena], I reviewed your latest patch and found the concurrent lifecycle implementation
a bit hard to understand and maintain. I tried to explain it and give suggestions in writing,
but in the end I found it easier and more productive to try an alternative implementation
by myself, which you can find [here|https://github.com/sbtourist/cassandra/commit/efe452846d29173e8b0d522651e7dc9f49f2597e];
in a nutshell, this implementation doesn't require any additional locks and manages a fully
thread safe lifecycle whose cases I tried to extensively test.

Let me know if you (and [~pauloricardomg]) have any feedback, and feel free to pull it in
your branch (just note the patch is implemented against [this|https://github.com/adelapena/cassandra/commit/c002d26255eaf53070a840d7232788e33f852e19]
commit in your branch, that is the one previous to your latest changes).


was (Author: sbtourist):
[~adelapena], I reviewed your latest patch and found the concurrent lifecycle implementation
a bit hard to understand and maintain. I tried to explain it and give suggestions in writing,
but in the end I found it easier and more productive to try an alternative implementation
by myself, which you can find [here|https://github.com/sbtourist/cassandra/commit/e1e316eae4d45a01aff7c86e1e21dc3a555e9ca5];
in a nutshell, this implementation doesn't require any additional locks and manages a fully
thread safe lifecycle whose cases I tried to extensively test.

Let me know if you (and [~pauloricardomg]) have any feedback, and feel free to pull it in
your branch (just note the patch is implemented against [this|https://github.com/adelapena/cassandra/commit/c002d26255eaf53070a840d7232788e33f852e19]
commit in your branch, that is the one previous to your latest changes).

> Node failure during 2i update after streaming can have incomplete 2i when restarted
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10130
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10130
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination
>            Reporter: Yuki Morishita
>            Assignee: Andrés de la Peña
>            Priority: Minor
>
> Since MV/2i update happens after SSTables are received, node failure during MV/2i update
can leave received SSTables live when restarted while MV/2i are partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at the startup, or
at least warn user when the node restarts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message